fix(editor): add "link to page" as first link action in Text menubar#2351
Merged
max-nextcloud merged 2 commits intomainfrom Mar 21, 2026
Merged
fix(editor): add "link to page" as first link action in Text menubar#2351max-nextcloud merged 2 commits intomainfrom
max-nextcloud merged 2 commits intomainfrom
Conversation
Member
Author
|
@marcoambrosini do you have suggestions for a better icon? The icon I chose is the one we use for pages in Collectives everywhere so far. I wonder whether we should change the "Link to file or folder" icon to a folder icon like the files app uses and keep the "Link to page" icon as it is above. |
marcoambrosini
approved these changes
Mar 19, 2026
Member
marcoambrosini
left a comment
marcoambrosini
left a comment
There was a problem hiding this comment.
Nice, makes sense to have the icon changed to folder here
Collaborator
|
I would also suggest we start the link to files file picker at the root directory rather than inside the collective. |
mejo-
added a commit
to nextcloud/text
that referenced
this pull request
Mar 19, 2026
Contributes to nextcloud/collectives#2351 Signed-off-by: Jonas <jonas@freesources.org>
2 tasks
backportbot bot
pushed a commit
to nextcloud/text
that referenced
this pull request
Mar 19, 2026
fix(link): use folder icon for "Link to file or folder" action Contributes to nextcloud/collectives#2351 Signed-off-by: Jonas <jonas@freesources.org> [skip ci]
backportbot bot
pushed a commit
to nextcloud/text
that referenced
this pull request
Mar 19, 2026
fix(link): use folder icon for "Link to file or folder" action Contributes to nextcloud/collectives#2351 Signed-off-by: Jonas <jonas@freesources.org> [skip ci]
mejo-
added a commit
to nextcloud/text
that referenced
this pull request
Mar 19, 2026
Contributes to nextcloud/collectives#2351 Signed-off-by: Jonas <jonas@freesources.org>
backportbot bot
pushed a commit
to nextcloud/text
that referenced
this pull request
Mar 19, 2026
Contributes to nextcloud/collectives#2351 Signed-off-by: Jonas <jonas@freesources.org>
mejo-
force-pushed
the
fix/link_menu_link_page
branch
from
f84f35f to
4a05ca1
Compare
Fixes: #2332 Requires nextcloud/text#8368 Signed-off-by: Jonas <jonas@freesources.org>
mejo-
force-pushed
the
fix/link_menu_link_page
branch
from
4a05ca1 to
9908134
Compare
max-nextcloud
approved these changes
Mar 21, 2026
Collaborator
|
Interesting... psalm failure seems to be deterministic - however I cannot reproduce it locally - neither on this nor the main branch. After updating my ocp locally I could reproduce the failure. I'll push an update to the phpstubs. |
nextcloud/server@42c6ffa#diff-a92210be3a561ec6a1435dfed15db42bb61cab953e3915b057aa0a3b3c30c879 Signed-off-by: Max <max@nextcloud.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #2332
Requires nextcloud/text#8368
Opens the smart picker with "collective page" provider preselected.
🖼️ Screenshots
🚧 TODO
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)