[Spring MVC] 김나윤 미션 제출합니다. #298
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
열심히 한 거 같아용, 저보다 잘해서 리뷰하기 살짝 부끄럽네요🫣 간단하게 코멘트 남겼어요, 남은 미션도 파이팅!! |
sojeong0202
reviewed
Jul 10, 2024
Comment on lines
+6
to
+13
| @Controller | ||
| public class HomeController { | ||
|
|
||
| @GetMapping("/") | ||
| public String home() { | ||
| return "home"; | ||
| } | ||
| } |
Comment on lines
+35
to
+36
| @GetMapping(value = "/reservations", produces = "application/json") | ||
| @ResponseBody |
There was a problem hiding this comment.
GetMapping의 produces가 무슨 역할을 하는지 궁금해용🤓
Comment on lines
+3
to
+20
| public class ApiResponseTemplate<T> { | ||
|
|
||
| private final String status; | ||
| private final T data; | ||
|
|
||
| public ApiResponseTemplate(String status, T data) { | ||
| this.status = status; | ||
| this.data = data; | ||
| } | ||
|
|
||
| public String getStatus() { | ||
| return status; | ||
| } | ||
|
|
||
| public T getData() { | ||
| return data; | ||
| } | ||
| } |
There was a problem hiding this comment.
이런 식으로 API 응답에서 상태 코드와 실질적인 데이터를 분리할 수 있군요 굿👍
Comment on lines
+79
to
+85
| @DeleteMapping("/reservations/{id}") | ||
| @ResponseBody | ||
| public ResponseEntity<ApiResponseTemplate<String>> deleteReservation(@PathVariable Long id) { | ||
| ensureReservationExists(id); | ||
| removeReservation(id); | ||
| return createSuccessDeleteResponse(); | ||
| } |
Comment on lines
+117
to
+123
| @PostMapping("/reservations/reset") | ||
| @ResponseBody | ||
| public ResponseEntity<Void> resetReservations() { | ||
| index.set(1); | ||
| reservations.clear(); | ||
| return new ResponseEntity<>(HttpStatus.NO_CONTENT); | ||
| } |
Comment on lines
15
to
16
| @SpringBootTest(webEnvironment = SpringBootTest.WebEnvironment.DEFINED_PORT) | ||
| @DirtiesContext(classMode = DirtiesContext.ClassMode.BEFORE_EACH_TEST_METHOD) |
There was a problem hiding this comment.
@SpringBootTest와 @DirtiesContext를 알고 계셨나요?
추가적으로 공부해서 알려주세용!🤓 (LBP 전체적인 숙제였읍니당,,,)
Comment on lines
+35
to
+36
| @Test | ||
| void 이단계() { |
There was a problem hiding this comment.
@DisplayName을 이용해서 테스트 메소드의 목적을 명시해볼까요?
한 문장으로 표현되지 않는다면 테스트 메소드를 분리해봅시당
Comment on lines
+3
to
+6
| public class BadRequestException extends IllegalArgumentException { | ||
| public BadRequestException(String message) { | ||
| super(message); | ||
| } |
shinheekim
reviewed
Jul 11, 2024
|
|
||
| @PostMapping("/reservations") | ||
| @ResponseBody | ||
| public ResponseEntity<ApiResponseTemplate<ReservationResDto>> addReservation(@RequestBody ReservationReqDto reservationReqDto) { |
There was a problem hiding this comment.
ApiResponseTemplate로 따로 더 감싸서 응답하는 이유는 뭔가용?
| import org.springframework.web.bind.annotation.ExceptionHandler; | ||
| import roomescape.template.ApiResponseTemplate; | ||
|
|
||
| @ControllerAdvice |
There was a problem hiding this comment.
@ControllerAdvice 어노테이션은 무슨 역할을 하나요?
shinheekim
approved these changes
Jul 11, 2024
ihwag719
reviewed
Jul 14, 2024
Comment on lines
+35
to
+36
| @GetMapping(value = "/reservations", produces = "application/json") | ||
| @ResponseBody |
| @@ -0,0 +1,20 @@ | |||
| package roomescape.template; | |||
|
|
|||
| public class ApiResponseTemplate<T> { | |||
There was a problem hiding this comment.
클래스 ApiResponseTemplate<T>에 대해서 설명해주실 수 있나요?
| class MissionStepTest { | ||
|
|
||
| @BeforeEach | ||
| void 초기화() { |
There was a problem hiding this comment.
초기화를 통해 테스트 환경을 일관되게 제공하려고 한 점 좋은 것 같습니다 굿
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.