[10기 이재훈] ToDoList CRUD #213
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyoungnam
reviewed
Jul 12, 2021
| $todoInput; | ||
| $todoList; | ||
| constructor(){ | ||
| const toDoInputTarget = document.querySelector("#new-todo-title"); |
There was a problem hiding this comment.
반복되는 document.querySelector를 유틸함수로 빼서 재사용해보는것도 좋을꺼 같아요.
| $target; | ||
| constructor(target){ | ||
| this.$target = target; | ||
| this.setState({ |
| this.$todoList = new ToDoList(toDoListTarget); | ||
| } | ||
| addToDoItem(itemTitle){ | ||
| this.$todoList.addItem(itemTitle); |
There was a problem hiding this comment.
todoList와 todoInput이 강하게 묶여 있습니다. observer 패턴형태를 참고해서 수정해도 좋을꺼 같습니다.
There was a problem hiding this comment.
넵넵 todoList 와 todoInput을 상위에서 묶음으로써 todoList 컴포넌트와 todoInput 컴포넌트의 state를 따로 관리하였고, 그로인해서 state 초기화가 달랐던것입니다! observer 패턴을 잘 모르지만 공부해서 반영해보도록 하겠습니다!
| addToggleEvent(){ | ||
| const toggleComponents = this.$target.querySelectorAll('.toggle'); | ||
| const {items} = this.state; | ||
| toggleComponents.forEach((element,idx) => { |
There was a problem hiding this comment.
모든 토글에 리스너를 등록하는 방법 대신 이벤트위임을 통해 부모 노드에만 이벤트를 등록하는 방법을 고려해보세요.
[(https://ko.javascript.info/event-delegation)]
HyeonHak
reviewed
Jul 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
삭제까지밖에 구현하지 못했습니다 ㅠㅠ 얼른해서 마무리 짓겠습니다!