Skip to content

fix: show files that matches configured file patterns in tree view#75

Merged
Fishbowler merged 4 commits into
devfrom
fix-tree-view
Apr 1, 2025
Merged

fix: show files that matches configured file patterns in tree view#75
Fishbowler merged 4 commits into
devfrom
fix-tree-view

Conversation

@Mastersam07
Copy link
Copy Markdown
Collaborator

@Mastersam07 Mastersam07 commented Mar 30, 2025

Fixes #65

treeExplorer.mp4

Copy link
Copy Markdown
Collaborator

@Fishbowler Fishbowler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments on completeness of the searching

Comment thread src/provider/treeView.ts
Comment thread src/provider/treeView.ts
Comment thread src/provider/treeView.ts
Comment thread src/provider/treeView.ts
Copy link
Copy Markdown
Collaborator

@Fishbowler Fishbowler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the issue for this repository.

With a config including "maestroWorkbench.filePatterns": ["tests/examples/*.yaml"], I had this experience:

Before - the 3 flow files appeared, but so did the typescript test file that uses them

After - the test file disappears, but the flows remain, as do a bunch of the files they reference (along with indicators that they're missing)

image

Will push that config to this branch

Apologies for the whitespace, darned formatters.
@Fishbowler
Copy link
Copy Markdown
Collaborator

The stuff for #77:

  • Deal with short format commands
  • Add retry.file
  • Account for file-hosting commands in:
    • onFlowStart
    • onFlowComplete
    • runFlow > commands (as noted below)
    • repeat > commands
    • retry > commands
  • Account for recursion in the above

@Fishbowler Fishbowler merged commit c43641c into dev Apr 1, 2025
@Mastersam07 Mastersam07 deleted the fix-tree-view branch April 1, 2025 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tree view won't display as shown in extension

2 participants