Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: change the slack channel instructions #2478

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nzur-newrelic
Copy link
Contributor

@nzur-newrelic nzur-newrelic commented Oct 3, 2023

Description

Change in the documentation due to a new feature that changed the behavior
Please include a summary of the change and which issue is fixed (if relevant).

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist:

Please delete options that are not relevant.

  • My commit message follows conventional commits
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • New and existing unit tests pass locally with my changes. Go here for instructions on running tests locally.

How to test this change?

Please describe how to test your changes. Include any relevant steps in the UI, HCL file(s), commands, etc

@codecov-commenter
Copy link

codecov-commenter commented Oct 4, 2023

Codecov Report

Merging #2478 (913e634) into main (f9aa096) will not change coverage.
Report is 2 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2478   +/-   ##
=======================================
  Coverage   33.87%   33.87%           
=======================================
  Files          91       91           
  Lines       24884    24884           
=======================================
  Hits         8429     8429           
  Misses      16300    16300           
  Partials      155      155           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@nzur-newrelic nzur-newrelic force-pushed the feat/NR-75529/change-tf-for-slack-channel-name branch from e2dda1a to 913e634 Compare October 5, 2023 07:42
@nzur-newrelic nzur-newrelic changed the title fix(workflows): ignore channelId when slack has channelName docs: change the slack channel instructions Oct 5, 2023
@nzur-newrelic nzur-newrelic marked this pull request as ready for review October 5, 2023 08:24
* `customDetailsSlack` - (Optional) A map of key/value pairs that represents the slack custom details. Must be compatible with Slack's blocks api.
* `channelId` - (Optional) Specifies the Slack channel id. This can be found in slack browser via the url. Example - https://app.slack.com/client/\<UserId>/\<ChannelId>.
* `channelName` - (Optional) Specifies the Slack channel name.
* `customDetailsSlack` - (Optional) A map of key/value pairs that represents the slack custom details. Must be compatible with Slack's blocks api. \
Copy link
Contributor

@Nandu-pns Nandu-pns Oct 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @nzur-newrelic - Was just reviewing this in doc preview, maybe better to use "<br>" instead of "\" at the end of line ?

@sanderblue sanderblue force-pushed the main branch 2 times, most recently from 23a73db to 4f7b20e Compare May 7, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants