Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: newrelic_notification_channel property should be optional and match what documentation says #2430

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

knapo
Copy link
Contributor

@knapo knapo commented Jul 21, 2023

Description

Some of newrelic_notification_channel types (e.g. EMAIL) does not require property and it shouldn't be a required value. Also documentation doesn't say it should be required and all possible properties for EMAIL are optional.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My commit message follows conventional commits
  • I have performed a self-review of my own code
  • New and existing unit tests pass locally with my changes. Go here for instructions on running tests locally.

@CLAassistant
Copy link

CLAassistant commented Jul 21, 2023

CLA assistant check
All committers have signed the CLA.

@knapo knapo changed the title fix: newrelic_notification_channel property to be optional fix: newrelic_notification_channel property should be optional and match what documentation says Jul 21, 2023
@knapo knapo marked this pull request as ready for review July 21, 2023 13:55
@sanderblue sanderblue force-pushed the main branch 2 times, most recently from 23a73db to 4f7b20e Compare May 7, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants