Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release now uses reusable workflow #511

Merged
merged 9 commits into from
Jan 20, 2025

Conversation

rahulreddy15
Copy link
Contributor

Tested the reusable workflow for pre releases.
This PR depends on newrelic/coreint-automation#103
Merge that and then point the job to the correct branch before merging

@rahulreddy15 rahulreddy15 requested a review from a team as a code owner December 17, 2024 11:48
@rahulreddy15
Copy link
Contributor Author

Pre release and release were tested successfully.
Point to the right workflow before merging.

Copy link
Member

@paologallinaharbur paologallinaharbur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please perform the small changes discussed before merging

@rahulreddy15 rahulreddy15 force-pushed the NR-341876-Make-docker-images-pre-release-uniform branch from f4bed41 to 824e86f Compare January 20, 2025 07:42
@rahulreddy15
Copy link
Contributor Author

The env variables used only by nri-prometheus are now set in the release_command_sh for nri-prometheus.

@rahulreddy15 rahulreddy15 merged commit 506915f into main Jan 20, 2025
14 checks passed
@rahulreddy15 rahulreddy15 deleted the NR-341876-Make-docker-images-pre-release-uniform branch January 20, 2025 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants