Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add pod startup metrics #964

Merged
merged 12 commits into from
Jan 8, 2024
Merged

feat: add pod startup metrics #964

merged 12 commits into from
Jan 8, 2024

Conversation

w21froster
Copy link
Contributor

@w21froster w21froster commented Dec 15, 2023 •
edited
Loading

Description

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New feature / enhancement (non-breaking change which adds functionality)
  • Security fix
  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • Add changelog entry following the contributing guide
  • Documentation has been updated
  • This change requires changes in testing:
    • unit tests
    • E2E tests

@CLAassistant
Copy link

CLAassistant commented Dec 15, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@w21froster w21froster marked this pull request as ready for review December 15, 2023 20:26
@w21froster w21froster requested a review from a team December 15, 2023 20:26
csongnr
csongnr approved these changes Dec 15, 2023
View reviewed changes
Copy link
Contributor

@csongnr csongnr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for the addition, lets wait for e2e tests before merge

@csongnr
Copy link
Contributor

csongnr commented Jan 8, 2024

ran e2e tests here : #969 because e2e testing doesn't work w/ prs from forked repos. all tests passed, so will be merging

@csongnr csongnr merged commit a91b1ca into newrelic:main Jan 8, 2024
15 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csongnr csongnr csongnr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@w21froster @CLAassistant @csongnr