Conversation
address 2 issues causing dependency detection to falsely label an instrumentation's dependencies as "unsatisfied". - handle Padrino with a special case pending resolution of #2912 - don't mark an item as unsatisfied the second (or higher) time it comes around through the `detect!` loop
fallwith
requested review from
hannahramadan,
kaylareopelle and
tannalynn
as code owners
use a string for comparison
Contributor
SimpleCov Report
|
tannalynn
approved these changes
Oct 17, 2024
| # already set for Sinatra, so skip Padrino and circle back with a | ||
| # new Padrino specific solution in the future. | ||
| # | ||
| # https://github.com/newrelic/newrelic-ruby-agent/issues/2912 |
Contributor
There was a problem hiding this comment.
Really appreciate the comment here about what's going on with this. thank you!
kaylareopelle
approved these changes
Oct 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
address 2 issues causing dependency detection to falsely label an instrumentation's dependencies as "unsatisfied".
detect!loopresolves #2893