Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(agent): Fixes monolog integration tests provisioning and clm tests #1028

Merged
merged 2 commits into from
Feb 24, 2025

Conversation

mfulb
Copy link
Contributor

@mfulb mfulb commented Feb 21, 2025

Fixes issues with the Monolog provisioning needed for the Monolog integration tests (Monolog 2 and 3) to run properly. Without this fix these tests are skipped.

Also fixes the CLM line number expectations as these changes with the updated Monolog versions used for the tests.

@mfulb mfulb requested a review from zsistla February 21, 2025 15:04
@newrelic-php-agent-bot
Copy link

newrelic-php-agent-bot commented Feb 21, 2025

Test Suite Status Result
Multiverse 8/8 passing
SOAK 76/79 passing

@mfulb mfulb requested a review from hahuja2 February 21, 2025 15:05
@codecov-commenter
Copy link

codecov-commenter commented Feb 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.58%. Comparing base (8a993c3) to head (5b4c439).

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1028      +/-   ##
==========================================
+ Coverage   77.05%   77.58%   +0.53%     
==========================================
  Files         198      198              
  Lines       27717    27715       -2     
==========================================
+ Hits        21357    21503     +146     
+ Misses       6360     6212     -148     
Flag Coverage Δ
agent-for-php-7.2 77.72% <ø> (+0.55%) ⬆️
agent-for-php-7.3 77.74% <ø> (+0.55%) ⬆️
agent-for-php-7.4 77.45% <ø> (+0.55%) ⬆️
agent-for-php-8.0 76.84% <ø> (+0.55%) ⬆️
agent-for-php-8.1 77.34% <ø> (+0.54%) ⬆️
agent-for-php-8.2 76.95% <ø> (?)
agent-for-php-8.3 76.95% <ø> (+0.54%) ⬆️
agent-for-php-8.4 76.97% <ø> (+0.54%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mfulb mfulb changed the base branch from main to dev February 24, 2025 15:18
@mfulb mfulb merged commit 11b67fa into dev Feb 24, 2025
65 checks passed
@mfulb mfulb deleted the fix/monolog-integration-tests-provisioning branch February 24, 2025 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants