-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Ruby example #345
Add Ruby example #345
Conversation
👋 Heya @kaylareopelle! Thanks for adding a Ruby example. You got this in draft, are you still working it? |
Hi @alanwest! Thanks for pinging me! This is ready for review 😄 |
Hey @kaylareopelle! Thank you so much for putting this Ruby example together, and for separating it out into the directories per our Get Started Guide example in Java! I just have a few notes:
Thanks again! |
Hi @reese-lee! Circling back to this today! I've addressed your feedback here: Here's a Ruby equivalent of the screenshot you shared: Please let me know if you need anything else! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Kayla! This looks pretty good to me. Unfortunately, I ran into issues with gems on my machine so I have not been able to run the app myself; if you can confirm that the trace data the app produces matches the trace data we're looking for here, I am good to get this merged!
Co-authored-by: Reese Lee <[email protected]>
@reese-lee - Sorry to hear you ran into trouble with gems! Here's a permalink to an app on staging with data from the instrumented app: https://staging.onenr.io/06vjAqpDnjP Things look quite similar. The only difference I see involves traces with errors: https://staging.onenr.io/0znQxBDeBRV |
@kaylareopelle I think that's good, that might just be how it's handled in Ruby. |
Great! In that case, please merge as you're able! (I don't have permission to do so) |
@kaylareopelle Okay! We chatted about your PR and it looks pretty good. We also talked about the error trace only having one span, and if you can modify the code so that the error is handled within the calculation, that will create a nested span on the error trace. Because right now it's not doing the calculation if the input is outside the valid range (see here). Does that make sense? |
Hi @reese-lee! Sorry about the delay here. I think that makes sense. Is this what you're looking for? https://staging.onenr.io/0kERzpxLlQr |
During a recent OpenTelemetry spike, the Ruby agent team created an application that closely mirrors the example in New Relic's Python OpenTelemetry Workshop.
We'd like to share this example with the community.