-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added getting started guide for Python #321
Conversation
This PR is to add a Get Started with OTel Python tutorial to our examples repo, similar to what we have for Java. The directories have already been broken out into @pnvnd Can you add the load generator files to each directory as well, which will be more convenient for users depending on which tutorial they want to try out in the guide? |
Thank you for making that change so promptly @pnvnd! A couple more things:
|
Standardizes the README to match the Java README
* remove the service name from being hardcoded (I added an instruction to set service name as an env var in the README) * update the meter description * update the returned json response for a valid input * update the ValueError message * remove the team tag `newrelic` * remove the "Everything else" section, I moved the two items to the `Traces` and `Metrics` sections respectively
Hello @pnvnd, thank you for your patience! I made a few changes to the following based on our recently written spec for the getting started demo apps:
There's just a few more things I could use your help with:
|
Hey @pnvnd It is looking really good! I ran the instrumented version, and the only thing I really noticed about the data in NR is that the error is not captured as a span event on the span on which it occurs. |
No description provided.