Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

**DRAFT** feat: AWS Account ID Parsing, DynamoDB relationship attribute #2911

Draft
wants to merge 7 commits into
base: feature/invoke-lambda-instrumentation
Choose a base branch
from

Conversation

tippmar-nr
Copy link
Member

Draft PR, includes AWS account id parsing and adds cloud.resource_id attribute to DynamoDB wrapper.

Target branch will change to 'main after #2901 is completed.

@tippmar-nr tippmar-nr requested a review from a team as a code owner December 2, 2024 21:29
@tippmar-nr tippmar-nr marked this pull request as draft December 2, 2024 21:30
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 30 lines in your changes missing coverage. Please review.

Project coverage is 81.37%. Comparing base (614270c) to head (96d40aa).

Files with missing lines Patch % Lines
...lic.Agent.Extensions/AwsSdk/AwsAccountIdDecoder.cs 0.00% 30 Missing ⚠️
Additional details and impacted files
@@                            Coverage Diff                            @@
##           feature/invoke-lambda-instrumentation    #2911      +/-   ##
=========================================================================
- Coverage                                  81.46%   81.37%   -0.09%     
=========================================================================
  Files                                        466      467       +1     
  Lines                                      29692    29722      +30     
  Branches                                    3305     3310       +5     
=========================================================================
- Hits                                       24188    24187       -1     
- Misses                                      4711     4742      +31     
  Partials                                     793      793              
Flag Coverage Δ
Agent 82.29% <0.00%> (-0.10%) ⬇️
Profiler 73.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...lic.Agent.Extensions/AwsSdk/AwsAccountIdDecoder.cs 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants