Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(install): remove duplicate tracking event and simplify error message #1521

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

Julien4218
Copy link
Contributor

@Julien4218 Julien4218 commented Oct 12, 2023

Duplicate events were tracked during the validateProfile( ), this PR remove the duplicate.
Also simplified the user facing error message to avoid confusing with license key, new user message below.

FATAL 401 response returned: Invalid credentials provided. Missing API key or an invalid API key was provided.

@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Merging #1521 (fb3caec) into main (6634468) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main    #1521   +/-   ##
=======================================
  Coverage   47.40%   47.40%           
=======================================
  Files         125      125           
  Lines        7716     7716           
=======================================
  Hits         3658     3658           
  Misses       3917     3917           
  Partials      141      141           
Files Coverage Δ
internal/synthetics/command_batch_run.go 5.26% <ø> (ø)
internal/install/command.go 31.65% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Julien4218 Julien4218 requested a review from sanderblue October 12, 2023 19:04
@Julien4218 Julien4218 merged commit 086905d into main Oct 12, 2023
25 of 26 checks passed
@Julien4218 Julien4218 deleted the fix/remove-dup-error-track branch October 12, 2023 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants