added mutex guards around appRun for code level metrics #958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. Can we drop the go.mod changes from this pr though? That is handled in #948. We're in a tricky spot because a lot is build on the app object, but we can also just access its elements at any time because its internal. I wish there was a good way to abstract it away a bit more, otherwise this may happen again. |
iamemilio
reviewed
Sep 5, 2024
iamemilio
previously approved these changes
Sep 5, 2024
|
Apparently my dev setup really wanted the go.mod to be sorted differently. It should be back to what's on the dev branch now. |
iamemilio
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrects access to the internal
app.app.runstructure by protecting that access with a mutex, in order to prevent race conditions.