test: Add tests for under 40 percent coverage #1078

mvicknr · 2025-08-06T16:04:52Z

Links

https://new-relic.atlassian.net/browse/NR-320174
https://new-relic.atlassian.net/browse/NR-448319

Details

Adding tests to cover code in newrelic folder that are less than 40%

Co-authored-by: Github Copilot <[email protected]>

codecov-commenter · 2025-08-06T16:05:48Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.04%. Comparing base (5a8a2a1) to head (6b7610f).
⚠️ Report is 3 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #1078      +/-   ##
===========================================
+ Coverage    74.88%   78.04%   +3.16%     
===========================================
  Files          159      159              
  Lines        15801    15811      +10     
===========================================
+ Hits         11832    12340     +508     
+ Misses        3558     3058     -500     
- Partials       411      413       +2

see 11 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a8a2a1...6b7610f. Read the comment docs.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Newrelic-Boomi · 2025-08-06T16:06:24Z

https://new-relic.atlassian.net/browse/NR-448707

Co-authored-by: Github Copilot <[email protected]>

v3/newrelic/adaptive_sampler_test.go

Co-authored-by: Github Copilot <[email protected]>

bduranleau-nr · 2025-08-15T15:00:45Z

v3/go.mod

@@ -3,6 +3,7 @@ module github.com/newrelic/go-agent/v3
 go 1.22

 require (
+	github.com/stretchr/testify v1.10.0


We should avoid requiring testing dependencies at the top level mod file. It looks like this is only used in the serverless_from_internal_test and could easily be replaced

I removed this and updated the test that was using it

mvicknr · 2025-08-15T16:52:26Z

v3/newrelic/internal_app_test.go

Please take a look at TestProcess function

mvicknr · 2025-08-15T17:58:13Z

Failures due to a new version of Go being released and 1.23 is too old. Upgrading will need to be done in a separate PR. https://new-relic.atlassian.net/browse/NR-451839

* test: Add tests and fix issues found with tests Co-authored-by: Github Copilot <[email protected]> * Test: Add missed case Co-authored-by: Github Copilot <[email protected]> * Fix: Remove unneeded if and fix test Co-authored-by: Github Copilot <[email protected]> --------- Co-authored-by: Github Copilot <[email protected]>

* test: Add tests and fix issues found with tests Co-authored-by: Github Copilot <[email protected]> * Chore: Cleanup and simplify Co-authored-by: Github Copilot <[email protected]> * chore: Naming fix * test: Check reset with new duration Co-authored-by: Github Copilot <[email protected]> * test: Fix test to precisely count ticks Co-authored-by: Github Copilot <[email protected]> --------- Co-authored-by: Github Copilot <[email protected]>

mvicknr · 2025-08-26T16:32:31Z

v3/newrelic/oom_monitor.go

already reviewed and merged into develop

mvicknr · 2025-08-26T16:32:44Z

v3/newrelic/oom_monitor_test.go

already reviewed and merged into develop

mvicknr · 2025-08-26T16:33:00Z

v3/newrelic/secure_agent.go

already reviewed and merged into develop

mvicknr · 2025-08-26T16:33:12Z

v3/newrelic/secure_agent_test.go

already reviewed and merged into develop

mvicknr · 2025-08-26T18:12:48Z

Replaced by #1082

test: Add tests

7b588af

Co-authored-by: Github Copilot <[email protected]>

mvicknr changed the base branch from master to develop August 6, 2025 16:05

Fix: Rename overloaded function

3c3f3c4

Co-authored-by: Github Copilot <[email protected]>

mvicknr commented Aug 6, 2025

View reviewed changes

v3/newrelic/adaptive_sampler_test.go Outdated Show resolved Hide resolved

mvicknr and others added 2 commits August 8, 2025 13:38

test: Cover sampler

0fa4a1d

Co-authored-by: Github Copilot <[email protected]>

test: Test internal app

288b37c

Co-authored-by: Github Copilot <[email protected]>

mvicknr marked this pull request as ready for review August 14, 2025 18:10

github-actions bot assigned mirackara Aug 14, 2025

bduranleau-nr reviewed Aug 15, 2025

View reviewed changes

mvicknr added 2 commits August 15, 2025 11:50

chore: Add comments for clarity

22fc34f

chore: Removing Testify use in newrelic package

315a8b9

mvicknr commented Aug 15, 2025

View reviewed changes

v3/newrelic/internal_app_test.go Outdated

Copy link

Collaborator Author

mvicknr Aug 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take a look at TestProcess function

mvicknr and others added 2 commits August 26, 2025 12:28

mvicknr changed the base branch from develop to master August 26, 2025 16:30

mvicknr changed the base branch from master to develop August 26, 2025 16:30

mvicknr commented Aug 26, 2025

View reviewed changes

v3/newrelic/oom_monitor.go

Copy link

Collaborator Author

mvicknr Aug 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

already reviewed and merged into develop

mvicknr commented Aug 26, 2025

View reviewed changes

v3/newrelic/oom_monitor_test.go

Copy link

Collaborator Author

mvicknr Aug 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

already reviewed and merged into develop

mvicknr commented Aug 26, 2025

View reviewed changes

v3/newrelic/secure_agent.go

Copy link

Collaborator Author

mvicknr Aug 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

already reviewed and merged into develop

mvicknr commented Aug 26, 2025

View reviewed changes

v3/newrelic/secure_agent_test.go

Copy link

Collaborator Author

mvicknr Aug 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

already reviewed and merged into develop

mvicknr closed this Aug 26, 2025

mvicknr deleted the mvick/add-to-under-40-tests branch August 26, 2025 18:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

test: Add tests for under 40 percent coverage #1078

test: Add tests for under 40 percent coverage #1078

Uh oh!

mvicknr commented Aug 6, 2025

Uh oh!

codecov-commenter commented Aug 6, 2025 •

edited

Loading

Uh oh!

Newrelic-Boomi commented Aug 6, 2025

Uh oh!

Uh oh!

bduranleau-nr Aug 15, 2025

Uh oh!

mvicknr Aug 15, 2025

Uh oh!

mvicknr Aug 15, 2025

Uh oh!

mvicknr commented Aug 15, 2025 •

edited

Loading

Uh oh!

mvicknr Aug 26, 2025

Uh oh!

mvicknr Aug 26, 2025

Uh oh!

mvicknr Aug 26, 2025

Uh oh!

mvicknr Aug 26, 2025

Uh oh!

mvicknr commented Aug 26, 2025

Uh oh!

Uh oh!

test: Add tests for under 40 percent coverage #1078

test: Add tests for under 40 percent coverage #1078

Uh oh!

Conversation

mvicknr commented Aug 6, 2025

Links

Details

Uh oh!

codecov-commenter commented Aug 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Newrelic-Boomi commented Aug 6, 2025

Uh oh!

Uh oh!

bduranleau-nr Aug 15, 2025

Choose a reason for hiding this comment

Uh oh!

mvicknr Aug 15, 2025

Choose a reason for hiding this comment

Uh oh!

mvicknr Aug 15, 2025

Choose a reason for hiding this comment

Uh oh!

mvicknr commented Aug 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mvicknr Aug 26, 2025

Choose a reason for hiding this comment

Uh oh!

mvicknr Aug 26, 2025

Choose a reason for hiding this comment

Uh oh!

mvicknr Aug 26, 2025

Choose a reason for hiding this comment

Uh oh!

mvicknr Aug 26, 2025

Choose a reason for hiding this comment

Uh oh!

mvicknr commented Aug 26, 2025

Uh oh!

Uh oh!

codecov-commenter commented Aug 6, 2025 •

edited

Loading

mvicknr commented Aug 15, 2025 •

edited

Loading