Fix incomplete bandit response time metrics #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a display bug reported in #489
The bug exists because there were assumptions in the Transaction processing logic that relied on behavior in cowboy that isn't present in bandit, specifically that cowboy would spawn a process to handle the request after the start telemetry was executed, so that process spawn had to be considered when processing total time.
The fix is to only apply that extra processing when the transaction is marked as coming from cowboy.
Also included is a modification to the Transaction breakdown metrics that will give those charts the total time to take into account.
Closes #489