Skip to content

Commit

Permalink
remove continue on error comment and add explanation for fuzzy match …
Browse files Browse the repository at this point in the history
…test assertion
  • Loading branch information
XiXiaPdx committed Jan 3, 2024
1 parent 4517415 commit a751519
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
1 change: 0 additions & 1 deletion .github/workflows/elixir.yml
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,6 @@ jobs:
integration_test:
name: Integration Tests - Elixir ${{matrix.elixir}} / OTP ${{matrix.otp}}
runs-on: ubuntu-20.04
# continue-on-error: true

strategy:
matrix:
Expand Down
4 changes: 3 additions & 1 deletion examples/apps/redix_example/test/redix_example_test.exs
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,9 @@ defmodule RedixExampleTest do
end)

assert err_event[:"peer.address"] == "localhost:6379"
assert err_event[:"redix.error"] =~ "timeout"
# On elixir 1.14 OTP 26, the error message is "unknown POSIX error: timeout"
# On elixir 1.12, the error message is " :timeout"
assert err_event[:"redix.error"] =~ " timeout"
end

defp request(path) do
Expand Down

0 comments on commit a751519

Please sign in to comment.