Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make it clear that we publicly just support timestamp as the log timestamp #19484

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

bmcfeely
Copy link
Contributor

@bmcfeely bmcfeely commented Dec 9, 2024

Give us some context

When looking into a support ticket, I noticed that the Logs API docs were confusing about which fields we'd use as a timestamp. This PR attempts to clarify that.

Note that log_timestamp is only used in built-in parsing rules, and we intentionally don't use that attribute as the log time, maybe because originally we weren't confident that the parsing rules could parse timestamps correctly?

Copy link

github-actions bot commented Dec 9, 2024

Hi @bmcfeely 👋

Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days.

We will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 10 to 20 minutes).

Copy link

netlify bot commented Dec 9, 2024

Deploy Preview for docs-website-netlify failed. Why did it fail? →

Name Link
🔨 Latest commit 63e3826
🔍 Latest deploy log https://app.netlify.com/sites/docs-website-netlify/deploys/675777437a621e0008059f42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants