Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: expand the query/route parameter section #19457

Merged
merged 2 commits into from
Dec 6, 2024

Conversation

brnhensley
Copy link
Contributor

This came out of a conversation with Bob on the Node team a few months ago and I forgot to make a PR for it until now. This config option is really confusing or a lot of customers so I think it's worth expanding with some concrete examples.

Please follow conventional commit standards
in your commit messages and pull request title.

Give us some context

  • What problems does this PR solve?
  • Add any context that will help us review your changes such as testing notes,
    links to related docs, screenshots, etc.
  • If your issue relates to an existing GitHub issue, please link to it.

This came out of a conversation with Bob on the Node team a few months ago and I forgot to make a PR for it until now.  This config option is really confusing or a lot of customers so I think it's worth expanding with some concrete examples.
Copy link

github-actions bot commented Dec 6, 2024

Hi @brnhensley 👋

Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days.

We will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 10 to 20 minutes).

Copy link

netlify bot commented Dec 6, 2024

Deploy Preview for docs-website-netlify ready!

Name Link
🔨 Latest commit 9929e46
🔍 Latest deploy log https://app.netlify.com/sites/docs-website-netlify/deploys/6752fe0db007f80008f0fb65
😎 Deploy Preview https://deploy-preview-19457--docs-website-netlify.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@WriteMayur WriteMayur self-requested a review December 6, 2024 05:43
@WriteMayur WriteMayur self-assigned this Dec 6, 2024
@WriteMayur WriteMayur added content requests related to docs site content from_internal Identifies issues/PRs from Relics (except writers) labels Dec 6, 2024
Copy link
Contributor

@WriteMayur WriteMayur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good!

@WriteMayur WriteMayur merged commit 49f45f0 into newrelic:develop Dec 6, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content requests related to docs site content from_internal Identifies issues/PRs from Relics (except writers)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants