Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(EntityHeader): Update documentation for the new Entity header #2238

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

bhashkarsharma
Copy link
Contributor

@bhashkarsharma bhashkarsharma commented Jul 20, 2023

Description

This PR updates the documentation to match the new Entity header. It is related to another PR on the docs-website.

Reviewer Notes

I noticed some things while making these changes, which can be improved upon:

  • The screenshots in the section are outdated. I searched for the app mentioned (hello-app-1), to update the screenshot, but wasn't able to find it.
  • The search redirect link in the first line does not work as expected anymore.
  • The metadata widget could be independent or might show up inside the '...' button (refer screenshots below).

Related Issue(s) / Ticket(s)

If there are any related GitHub Issues or JIRA tickets, add links to them here.

Screenshot(s)

New header with metadata and tags widgets:

Screenshot 2023-07-20 at 17 37 29 Screenshot 2023-07-20 at 17 58 34

Use Conventional Commits

Please help the maintainers by leveraging the following conventional commit
standards in your pull request title and commit messages.

Use chore

  • for minor changes / additions / corrections to content.
  • for minor changes / additions / corrections to images.
  • for minor non-functional changes / additions to github actions, github templates, package or config updates, etc
git commit -m "chore: adjusting config and content"

Use fix

  • for minor functional corrections to code.
git commit -m "fix: typo and prop error in the code of conduct"

Use feat

  • for major functional changes or additions to code.
git commit -m "feat(media): creating a video landing page"

@CLAassistant
Copy link

CLAassistant commented Jul 20, 2023

CLA assistant check
All committers have signed the CLA.

@bhashkarsharma
Copy link
Contributor Author

I have signed the CLA.

@nbaenam nbaenam self-requested a review August 1, 2023 09:30
@nbaenam nbaenam self-assigned this Aug 1, 2023
@nbaenam nbaenam added the content label Aug 1, 2023
@nbaenam nbaenam closed this Aug 1, 2023
@nbaenam nbaenam reopened this Aug 1, 2023
@nbaenam nbaenam removed their request for review August 1, 2023 09:43
@nbaenam nbaenam removed their assignment Aug 1, 2023
@nbaenam nbaenam removed the content label Aug 1, 2023
@tabathadelane tabathadelane merged commit fc9ab51 into newrelic:develop Aug 1, 2023
2 checks passed
@nr-opensource-bot
Copy link
Contributor

🎉 This PR is included in version 1.96.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants