API Endpoint Phase 2: Add Endpoint route in Servlet Framework #270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IshikaDawda
force-pushed
the
feature/api-endpoint/Servlet-NR-273606
branch
from
3911256 to
b823e8d
Compare
Fix for NoSuchMethodError observed in servlet-3.0 route detection
* Detecting route servlet registration or servlet mapping
…73606 # Conflicts: # instrumentation-security/servlet-5.0/src/test/java/com/nr/agent/security/instrumentation/servlet5/HttpSessionTest.java # instrumentation-security/servlet-6.0/src/test/java/com/nr/agent/security/instrumentation/servlet6/HttpSessionTest.java # newrelic-security-agent/src/main/java/com/newrelic/api/agent/security/Agent.java
lovesh-ap
previously approved these changes
Sep 20, 2024
…73606 # Conflicts: # instrumentation-security/servlet-3.0/src/main/java/com/newrelic/agent/security/instrumentation/servlet30/HttpServletHelper.java
…73606 # Conflicts: # newrelic-security-api/src/main/java/com/newrelic/api/agent/security/schema/HttpRequest.java
…73606 # Conflicts: # instrumentation-security/servlet-2.4/src/main/java/com/newrelic/agent/security/instrumentation/servlet24/HttpServletHelper.java # instrumentation-security/servlet-2.4/src/main/java/javax/servlet/Servlet_Instrumentation.java # instrumentation-security/servlet-5.0/src/main/java/jakarta/servlet/FilterChain_Instrumentation.java # instrumentation-security/servlet-5.0/src/main/java/jakarta/servlet/Filter_Instrumentation.java # instrumentation-security/servlet-5.0/src/main/java/jakarta/servlet/Servlet_Instrumentation.java # instrumentation-security/servlet-6.0/src/main/java/jakarta/servlet/FilterChain_Instrumentation.java # instrumentation-security/servlet-6.0/src/main/java/jakarta/servlet/Filter_Instrumentation.java # instrumentation-security/servlet-6.0/src/main/java/jakarta/servlet/Servlet_Instrumentation.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detect route of an incoming request for servlet based servers.
Please note: To be merge after pull request #375