Skip to content

Add Trivy security scanning workflow to aws-unified-lambda - #64

Closed
app-dp-ci-autopilot[bot] wants to merge 1 commit into
mainfrom
add-trivy-workflow
Closed

app-dp-ci-autopilot[bot] wants to merge 1 commit into
mainfrom
add-trivy-workflow

Conversation

@app-dp-ci-autopilot

Copy link
Copy Markdown

This pull request adds a Trivy security scanning workflow. It was
raised automatically by dp-ci-autopilot on behalf of this repository's
integration enrollment.

Trivy scans the filesystem and the Docker image for HIGH and CRITICAL
vulnerabilities on a daily schedule, and uploads the results to this
repository's Security tab.

dp-ci-autopilot will not merge this pull request. Please review and merge
it yourself once the required checks on this repository have passed.

Merging this file should NOT lead to Grand Central builds / deployments
for services associated with this repo.

Enables Trivy Security Scans for filesystem and Docker images.

Committing this file to the repo at this path should NOT
lead to Grand Central builds / deployments for services
associated with this repo.
Comment on lines +10 to +33
name: Trivy Filesystem Scan
runs-on: ubuntu-latest

steps:
- name: Checkout code
uses: actions/checkout@v4

- name: Run Trivy filesystem scan
uses: aquasecurity/trivy-action@master
with:
scan-type: 'fs'
scan-ref: '.'
ignore-unfixed: true
severity: 'HIGH,CRITICAL'
format: 'sarif'
output: 'trivy-fs-results.sarif'

- name: Upload Trivy filesystem results to GitHub Security tab
if: always()
uses: github/codeql-action/upload-sarif@v3
with:
sarif_file: 'trivy-fs-results.sarif'

trivy_image_scan:
Comment on lines +34 to +63
name: Trivy Docker Image Scan
runs-on: ubuntu-latest

steps:
- name: Checkout code
uses: actions/checkout@v4

- name: Build and load Docker image
uses: docker/build-push-action@v6
with:
context: ./logs-function
file: ./logs-function/Dockerfile
load: true
tags: oci-log-integration-scan:latest

- name: Run Trivy image scan
uses: aquasecurity/trivy-action@master
with:
scan-type: 'image'
image-ref: 'oci-log-integration-scan:latest'
ignore-unfixed: true
severity: 'HIGH,CRITICAL'
format: 'sarif'
output: 'trivy-image-results.sarif'

- name: Upload Trivy image results to GitHub Security tab
if: always()
uses: github/codeql-action/upload-sarif@v3
with:
sarif_file: 'trivy-image-results.sarif' No newline at end of file
uses: docker/build-push-action@v6
with:
context: ./logs-function
file: ./logs-function/Dockerfile

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

he trivy_image_scan job builds from ./logs-function/Dockerfile (lines 41-42). That path doesn't exist, and the repo has no Dockerfile.

uses: aquasecurity/trivy-action@master
with:
scan-type: 'image'
image-ref: 'oci-log-integration-scan:latest'

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no oci-log-integration-scan:latest tag isnt from this repo

jobs:
trivy_fs_scan:
name: Trivy Filesystem Scan
runs-on: ubuntu-latest

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It duplicates github/workflows/trivy_schedule.yaml which already runs a daily filesystem scan for HIGH and github/workflows/pull_request.yaml#L91-L116) also runs Trivy on every PR.

format: 'sarif'
output: 'trivy-fs-results.sarif'

- name: Upload Trivy filesystem results to GitHub Security tab

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing permissions.
The upload steps at lines 26-29 and 57-60 need security-events: write permission

on:
schedule:
# Run every day at 12 AM IST (which is 6:30 PM UTC)
- cron: "46 7 * * *"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lines 5-6: the comment says 12 AM IST / 6:30 PM UTC, but 46 7 * * * is 07:46 UTC, which is 1:16 PM IST.

ignore-unfixed: true
severity: 'HIGH,CRITICAL'
format: 'sarif'
output: 'trivy-fs-results.sarif'

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The scan steps at lines 18-26 and 49-56 never fail the run. Compare withgithub/workflows/trivy_schedule.yaml#L34.

@pbhadra0112

Copy link
Copy Markdown

Agree with everything above — nothing to add on the substance. Two small notes:

  1. aquasecurity/trivy-action@master here is an unpinned floating ref; the existing trivy_schedule.yaml pins to a commit SHA. Worth matching that convention if any of this ever gets reused.
  2. This exact diff (same oci-log-integration-scan:latest tag, same ./logs-function path) also showed up identically in azure-vnet-flow-logs#32 and fluent-bit-package#276 — confirms it's a bug in dp-ci-autopilot's template itself, not a one-off here. Probably worth reporting to whoever owns that bot rather than closing these one repo at a time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants