Repository navigation
Add Trivy security scanning workflow to aws-unified-lambda - #64
app-dp-ci-autopilot[bot] wants to merge 1 commit into
Conversation
Enables Trivy Security Scans for filesystem and Docker images. Committing this file to the repo at this path should NOT lead to Grand Central builds / deployments for services associated with this repo.
| name: Trivy Filesystem Scan | ||
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - name: Checkout code | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Run Trivy filesystem scan | ||
| uses: aquasecurity/trivy-action@master | ||
| with: | ||
| scan-type: 'fs' | ||
| scan-ref: '.' | ||
| ignore-unfixed: true | ||
| severity: 'HIGH,CRITICAL' | ||
| format: 'sarif' | ||
| output: 'trivy-fs-results.sarif' | ||
|
|
||
| - name: Upload Trivy filesystem results to GitHub Security tab | ||
| if: always() | ||
| uses: github/codeql-action/upload-sarif@v3 | ||
| with: | ||
| sarif_file: 'trivy-fs-results.sarif' | ||
|
|
||
| trivy_image_scan: |
| name: Trivy Docker Image Scan | ||
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - name: Checkout code | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Build and load Docker image | ||
| uses: docker/build-push-action@v6 | ||
| with: | ||
| context: ./logs-function | ||
| file: ./logs-function/Dockerfile | ||
| load: true | ||
| tags: oci-log-integration-scan:latest | ||
|
|
||
| - name: Run Trivy image scan | ||
| uses: aquasecurity/trivy-action@master | ||
| with: | ||
| scan-type: 'image' | ||
| image-ref: 'oci-log-integration-scan:latest' | ||
| ignore-unfixed: true | ||
| severity: 'HIGH,CRITICAL' | ||
| format: 'sarif' | ||
| output: 'trivy-image-results.sarif' | ||
|
|
||
| - name: Upload Trivy image results to GitHub Security tab | ||
| if: always() | ||
| uses: github/codeql-action/upload-sarif@v3 | ||
| with: | ||
| sarif_file: 'trivy-image-results.sarif' No newline at end of file |
| uses: docker/build-push-action@v6 | ||
| with: | ||
| context: ./logs-function | ||
| file: ./logs-function/Dockerfile |
There was a problem hiding this comment.
he trivy_image_scan job builds from ./logs-function/Dockerfile (lines 41-42). That path doesn't exist, and the repo has no Dockerfile.
| uses: aquasecurity/trivy-action@master | ||
| with: | ||
| scan-type: 'image' | ||
| image-ref: 'oci-log-integration-scan:latest' |
There was a problem hiding this comment.
no oci-log-integration-scan:latest tag isnt from this repo
| jobs: | ||
| trivy_fs_scan: | ||
| name: Trivy Filesystem Scan | ||
| runs-on: ubuntu-latest |
There was a problem hiding this comment.
It duplicates github/workflows/trivy_schedule.yaml which already runs a daily filesystem scan for HIGH and github/workflows/pull_request.yaml#L91-L116) also runs Trivy on every PR.
| format: 'sarif' | ||
| output: 'trivy-fs-results.sarif' | ||
|
|
||
| - name: Upload Trivy filesystem results to GitHub Security tab |
There was a problem hiding this comment.
Missing permissions.
The upload steps at lines 26-29 and 57-60 need security-events: write permission
| on: | ||
| schedule: | ||
| # Run every day at 12 AM IST (which is 6:30 PM UTC) | ||
| - cron: "46 7 * * *" |
There was a problem hiding this comment.
Lines 5-6: the comment says 12 AM IST / 6:30 PM UTC, but 46 7 * * * is 07:46 UTC, which is 1:16 PM IST.
| ignore-unfixed: true | ||
| severity: 'HIGH,CRITICAL' | ||
| format: 'sarif' | ||
| output: 'trivy-fs-results.sarif' |
There was a problem hiding this comment.
The scan steps at lines 18-26 and 49-56 never fail the run. Compare withgithub/workflows/trivy_schedule.yaml#L34.
|
Agree with everything above — nothing to add on the substance. Two small notes:
|
This pull request adds a Trivy security scanning workflow. It was
raised automatically by dp-ci-autopilot on behalf of this repository's
integration enrollment.
Trivy scans the filesystem and the Docker image for HIGH and CRITICAL
vulnerabilities on a daily schedule, and uploads the results to this
repository's Security tab.
dp-ci-autopilot will not merge this pull request. Please review and merge
it yourself once the required checks on this repository have passed.
Merging this file should NOT lead to Grand Central builds / deployments
for services associated with this repo.