Skip to content

Fix failing e2e test: add unique resource name suffixes to prevent conflicts in run-e2e-tests-lambda-firehose-metrics - #57

Merged
rohit-bandlamudi-nr merged 4 commits into
mainfrom
NR-561943-JP-Region-Migration-aws-unified-lambda
Jun 9, 2026
Merged

rohit-bandlamudi-nr merged 4 commits into
mainfrom
NR-561943-JP-Region-Migration-aws-unified-lambda

Conversation

@rohit-bandlamudi-nr

@rohit-bandlamudi-nr rohit-bandlamudi-nr commented Jun 1, 2026 •

Copy link
Copy Markdown
Contributor

Root Cause

The failing CI job run-e2e-tests-lambda-firehose-metrics runs 6 sequential test cases that shared the same AWS resource names across all tests:

  • S3BackupBucketName="firehose-backup" — used by tests 2, 4, and 6 (lambda metric streaming, firehose metric streaming, lambda firehose metric streaming) without unique suffixes
  • LoggingS3BackupBucketName="firehose-logging-backup" — used by tests 3, 4, 5, and 6 without unique suffixes
  • IntegrationName="AWS-API-Polling-2025Feb11D10H48M12S" — used by all 6 tests without unique suffixes

These shared names caused conflicts: S3 buckets retained from earlier tests (due to DeletionPolicy: Retain in the external newrelic-cloudformation-mstreams.yml template) and/or NerdGraph API conflicts when the same integration name was reused across sequential test runs, causing the 6th (last) test to consistently fail in NewrelicMetricStreamsStack.

Changes Made

Updated e2e-tests/common-scripts/stack-scripts.sh to add unique ordinal suffixes (-second through -seventh) to the following parameters in all 6 deploy functions:

  • IntegrationName — unique per test case to prevent NerdGraph API conflicts
  • S3BackupBucketName — unique per streaming test (tests 2, 4, 6) to prevent S3 bucket naming conflicts
  • LoggingS3BackupBucketName — unique per logging test (tests 3, 4, 5, 6) to prevent S3 bucket naming conflicts

This follows the existing naming convention already established for FirehoseStreamName (-third, -fifth, -seventh), CloudWatchMetricStreamName, and LoggingFirehoseStreamName in the same file.

@voorepreethi voorepreethi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@voorepreethi

Copy link
Copy Markdown
Contributor

I see few tests are failing , please check

@voorepreethi voorepreethi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check e2e

maya-jha
maya-jha previously approved these changes Jun 3, 2026
voorepreethi
voorepreethi previously approved these changes Jun 3, 2026
voorepreethi
voorepreethi previously approved these changes Jun 3, 2026
voorepreethi
voorepreethi previously approved these changes Jun 3, 2026
hrai-nr
hrai-nr previously approved these changes Jun 3, 2026
voorepreethi
voorepreethi previously approved these changes Jun 8, 2026
Copilot AI dismissed stale reviews from voorepreethi and hrai-nr via 7e7d2ef June 8, 2026 10:09
Copilot AI changed the title feat(nr-client): upgraded nr client to point to new JP endpoint Fix failing e2e test: add unique resource name suffixes to prevent conflicts in run-e2e-tests-lambda-firehose-metrics Jun 8, 2026
Copilot AI requested a review from voorepreethi June 8, 2026 10:10
hrai-nr
hrai-nr previously approved these changes Jun 8, 2026
@voorepreethi
voorepreethi deleted the NR-561943-JP-Region-Migration-aws-unified-lambda branch June 8, 2026 12:58
@voorepreethi
voorepreethi restored the NR-561943-JP-Region-Migration-aws-unified-lambda branch June 9, 2026 06:39
@voorepreethi voorepreethi reopened this Jun 9, 2026
@voorepreethi
voorepreethi force-pushed the NR-561943-JP-Region-Migration-aws-unified-lambda branch from 7e7d2ef to 02f7000 Compare June 9, 2026 06:50
@rohit-bandlamudi-nr
rohit-bandlamudi-nr merged commit f93b466 into main Jun 9, 2026
121 of 141 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants