Repository navigation
Fix failing e2e test: add unique resource name suffixes to prevent conflicts in run-e2e-tests-lambda-firehose-metrics - #57
Merged
rohit-bandlamudi-nr merged 4 commits intoJun 9, 2026
Conversation
Contributor
|
I see few tests are failing , please check |
maya-jha
previously approved these changes
Jun 3, 2026
voorepreethi
previously approved these changes
Jun 3, 2026
rohit-bandlamudi-nr
dismissed stale reviews from voorepreethi and maya-jha
via
June 3, 2026 09:57
3eb4062
voorepreethi
previously approved these changes
Jun 3, 2026
voorepreethi
previously approved these changes
Jun 3, 2026
hrai-nr
previously approved these changes
Jun 3, 2026
voorepreethi
previously approved these changes
Jun 8, 2026
Copilot
AI
changed the title
feat(nr-client): upgraded nr client to point to new JP endpoint
Fix failing e2e test: add unique resource name suffixes to prevent conflicts in run-e2e-tests-lambda-firehose-metrics
Jun 8, 2026
hrai-nr
approved these changes
Jun 8, 2026
hrai-nr
previously approved these changes
Jun 8, 2026
voorepreethi
restored the
NR-561943-JP-Region-Migration-aws-unified-lambda
branch
June 9, 2026 06:39
voorepreethi
force-pushed
the
NR-561943-JP-Region-Migration-aws-unified-lambda
branch
from
June 9, 2026 06:50
7e7d2ef to
02f7000
Compare
voorepreethi
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root Cause
The failing CI job
run-e2e-tests-lambda-firehose-metricsruns 6 sequential test cases that shared the same AWS resource names across all tests:S3BackupBucketName="firehose-backup"— used by tests 2, 4, and 6 (lambda metric streaming, firehose metric streaming, lambda firehose metric streaming) without unique suffixesLoggingS3BackupBucketName="firehose-logging-backup"— used by tests 3, 4, 5, and 6 without unique suffixesIntegrationName="AWS-API-Polling-2025Feb11D10H48M12S"— used by all 6 tests without unique suffixesThese shared names caused conflicts: S3 buckets retained from earlier tests (due to
DeletionPolicy: Retainin the externalnewrelic-cloudformation-mstreams.ymltemplate) and/or NerdGraph API conflicts when the same integration name was reused across sequential test runs, causing the 6th (last) test to consistently fail inNewrelicMetricStreamsStack.Changes Made
Updated
e2e-tests/common-scripts/stack-scripts.shto add unique ordinal suffixes (-secondthrough-seventh) to the following parameters in all 6 deploy functions:IntegrationName— unique per test case to prevent NerdGraph API conflictsS3BackupBucketName— unique per streaming test (tests 2, 4, 6) to prevent S3 bucket naming conflictsLoggingS3BackupBucketName— unique per logging test (tests 3, 4, 5, 6) to prevent S3 bucket naming conflictsThis follows the existing naming convention already established for
FirehoseStreamName(-third,-fifth,-seventh),CloudWatchMetricStreamName, andLoggingFirehoseStreamNamein the same file.