Fixed issue 167 #180
Open
Fixed issue 167 #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue 167
This pull request attend to fix the issue 167.
The subject of the issue was the non-functionality of the Top Navigation elements. When we clicked on the Steps, the app where returning us
undefinedand we were not changing the current step.The bug was there because when we clicked on Steps, it was not the
<li/>elements that were trigger (the element where thejumpToStepfunction is called but it was its children (<em/>and<span/>).In order to fix this I've added an inline style property
pointer-events: none;to each of the children of the<li/>element.This way when we click on the
<Step/>it's always the<li/>element which is trigger, so thejumpToStepis called and StepZilla works correctly.