Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NVSHAS-9584: Update scanner to use upstream package #188

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

kyledong-suse
Copy link

@kyledong-suse kyledong-suse commented Jan 16, 2025

  1. Add upstream package github.com/coreos/clair
  2. Update neuvector vendor
  3. Update usage for extract functions based on neuvector repo's change

@kyledong-suse kyledong-suse requested review from yasker and a team as code owners January 16, 2025 19:27
@kyledong-suse
Copy link
Author

The unit test failure is expected as it requires neuvector/neuvector#1722 to be merged first.

1. Add upstream package github.com/coreos/clair
2. Update usage for tar functions based on neuvector repo's change
@kyledong-suse kyledong-suse changed the title NVSHAS-9584: Add package github.com/coreos/clair NVSHAS-9584: Update scanner to use upstream package Jan 21, 2025
Copy link
Collaborator

@holyspectral holyspectral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a comment about error handling. However given that it's from the existing code, it's not blocking this PR.

Just a reminder that scanner will be published after this change, so please have some tests before merging.

cvetools/image.go Outdated Show resolved Hide resolved
1. Add upstream package github.com/coreos/clair
2. Update neuvector vendor
3. Update usage for extract functions based on neuvector repo's change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants