Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update env #134

Closed
wants to merge 13 commits into from
Closed

update env #134

wants to merge 13 commits into from

Conversation

searscr
Copy link
Contributor

@searscr searscr commented May 20, 2024

Short description of the changes:

Long description of the changes:

Check list for the pull request

  • I have read the [CONTRIBUTING]
  • I have read the [CODE_OF_CONDUCT]
  • I have added tests for my changes
  • I have updated the documentation accordingly

Check list for the reviewer

  • I have read the [CONTRIBUTING]
  • I have verified the proposed changes
  • best software practices
    • all internal functions have an underbar, as is python standard
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

Manual test for the reviewer

References

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 83.33333% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 80.64%. Comparing base (a9297e4) to head (7922865).
Report is 6 commits behind head on next.

Current head 7922865 differs from pull request most recent head 70a903a

Please upload reports for the commit 70a903a to get more accurate results.

Files Patch % Lines
src/shiver/views/oncat.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             next     #134      +/-   ##
==========================================
- Coverage   82.30%   80.64%   -1.67%     
==========================================
  Files          39       39              
  Lines        6048     6206     +158     
==========================================
+ Hits         4978     5005      +27     
- Misses       1070     1201     +131     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@searscr searscr closed this May 20, 2024
@searscr searscr deleted the ewm4465_2 branch May 20, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants