Skip to content

Fix ref with sibling id from 2019-09 #1203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 20, 2025
Merged

Fix ref with sibling id from 2019-09 #1203

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/main/java/com/networknt/schema/keyword/RefValidator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
import com.networknt.schema.Schema;
import com.networknt.schema.SchemaException;
import com.networknt.schema.SchemaRef;
import com.networknt.schema.SpecificationVersion;
import com.networknt.schema.path.NodePath;
import com.networknt.schema.utils.ThreadSafeCachingSupplier;
import com.networknt.schema.SchemaLocation;
Expand Down Expand Up @@ -146,7 +147,8 @@ private static void copySchemaResources(SchemaContext schemaContext, Schema sche
private static String resolve(Schema parentSchema, String refValue) {
// $ref prevents a sibling $id from changing the base uri
Schema base = parentSchema;
if (parentSchema.getId() != null && parentSchema.getParentSchema() != null) {
if (parentSchema.getId() != null && parentSchema.getParentSchema() != null && parentSchema.getSchemaContext()
.getDialect().getSpecificationVersion().getOrder() <= SpecificationVersion.DRAFT_7.getOrder()) {
base = parentSchema.getParentSchema();
}
return SchemaLocation.resolve(base.getSchemaLocation(), refValue);
Expand Down
92 changes: 92 additions & 0 deletions src/test/java/com/networknt/schema/RefValidatorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@

import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertFalse;
import static org.junit.jupiter.api.Assertions.assertTrue;

import java.util.Collections;
import java.util.List;
Expand Down Expand Up @@ -134,4 +135,95 @@ void classPathNoSlash() {
+ "}";
assertFalse(schema.validate(inputData, InputFormat.JSON, OutputFormat.BOOLEAN));
}

@Test
void refSiblingId07AndBelow() {
String schemaData = "{\r\n"
+ " \"$id\": \"http://localhost:1234/sibling_id/base/\",\r\n"
+ " \"definitions\": {\r\n"
+ " \"foo\": {\r\n"
+ " \"$id\": \"http://localhost:1234/sibling_id/foo.json\",\r\n"
+ " \"type\": \"string\"\r\n"
+ " },\r\n"
+ " \"base_foo\": {\r\n"
+ " \"$comment\": \"this canonical uri is http://localhost:1234/sibling_id/base/foo.json\",\r\n"
+ " \"$id\": \"foo.json\",\r\n"
+ " \"type\": \"number\"\r\n"
+ " }\r\n"
+ " },\r\n"
+ " \"allOf\": [\r\n"
+ " {\r\n"
+ " \"$comment\": \"$ref resolves to http://localhost:1234/sibling_id/base/foo.json, not http://localhost:1234/sibling_id/foo.json\",\r\n"
+ " \"$id\": \"http://localhost:1234/sibling_id/\",\r\n"
+ " \"$ref\": \"foo.json\"\r\n"
+ " }\r\n"
+ " ]\r\n"
+ "}";
SchemaRegistry factory = SchemaRegistry.withDefaultDialect(SpecificationVersion.DRAFT_7);
Schema schema = factory.getSchema(schemaData);
String inputData = "1";
assertTrue(schema.validate(inputData, InputFormat.JSON, OutputFormat.BOOLEAN));
}

@Test
void refSiblingId201909AndAbove() {
String schemaData = "{\r\n"
+ " \"$id\": \"http://localhost:1234/sibling_id/base/\",\r\n"
+ " \"definitions\": {\r\n"
+ " \"foo\": {\r\n"
+ " \"$id\": \"http://localhost:1234/sibling_id/foo.json\",\r\n"
+ " \"type\": \"string\"\r\n"
+ " },\r\n"
+ " \"base_foo\": {\r\n"
+ " \"$comment\": \"this canonical uri is http://localhost:1234/sibling_id/base/foo.json\",\r\n"
+ " \"$id\": \"foo.json\",\r\n"
+ " \"type\": \"number\"\r\n"
+ " }\r\n"
+ " },\r\n"
+ " \"allOf\": [\r\n"
+ " {\r\n"
+ " \"$comment\": \"$ref resolves to http://localhost:1234/sibling_id/base/foo.json, not http://localhost:1234/sibling_id/foo.json\",\r\n"
+ " \"$id\": \"http://localhost:1234/sibling_id/\",\r\n"
+ " \"$ref\": \"foo.json\"\r\n"
+ " }\r\n"
+ " ]\r\n"
+ "}";
SchemaRegistry factory = SchemaRegistry.withDefaultDialect(SpecificationVersion.DRAFT_2019_09);
Schema schema = factory.getSchema(schemaData);
String inputData = "\"a\"";
assertTrue(schema.validate(inputData, InputFormat.JSON, OutputFormat.BOOLEAN));
}

@Test
void refSiblingIdInner201909AndAbove() {
String schemaData = "{\r\n"
+ " \"$schema\": \"https://json-schema.org/draft/2020-12/schema\",\r\n"
+ " \"$id\": \"http://example.com/schema-relative-uri-defs1.json\",\r\n"
+ " \"properties\": {\r\n"
+ " \"foo\": {\r\n"
+ " \"$id\": \"schema-relative-uri-defs2.json\",\r\n"
+ " \"$defs\": {\r\n"
+ " \"inner\": {\r\n"
+ " \"properties\": {\r\n"
+ " \"bar\": {\r\n"
+ " \"type\": \"string\"\r\n"
+ " }\r\n"
+ " }\r\n"
+ " }\r\n"
+ " },\r\n"
+ " \"$ref\": \"#/$defs/inner\"\r\n"
+ " }\r\n"
+ " },\r\n"
+ " \"$ref\": \"schema-relative-uri-defs2.json\"\r\n"
+ "}";
SchemaRegistry factory = SchemaRegistry.withDefaultDialect(SpecificationVersion.DRAFT_2019_09);
Schema schema = factory.getSchema(schemaData);
String inputData = "{\r\n"
+ " \"foo\": {\r\n"
+ " \"bar\": \"a\"\r\n"
+ " },\r\n"
+ " \"bar\": \"a\"\r\n"
+ "}";
assertTrue(schema.validate(inputData, InputFormat.JSON, OutputFormat.BOOLEAN));
}
}