Fix references resolved by xml2rfc #185
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The xml2rfc tool could not resolve the references in the yang-module-versioning draft. Also removes rfc-6991-bis reference, unused import, see #172.
rgwilton
reviewed
Nov 29, 2022
| <?rfc include='reference.RFC.8525'?> | ||
| <?ref include='reference.I-D.ietf-netmod-yang-semver'?> | ||
| <?ref include='reference.I-D.ietf-netmod-rfc6991-bis'?> | ||
| <?rfc include='reference.RFC.2119.xml'?> |
There was a problem hiding this comment.
I'm not sure why we need to add .xml to the references, this looks unusual to me. But I agree with removing the stale reference to rfc6991-bis
There was a problem hiding this comment.
Actually, we import ietf-netmod-rfc6991-bis in the YANG module, so I think that the fix is to go the other way and explicitly state and reference that module.
There was a problem hiding this comment.
Please can you still check that it works with:
There was a problem hiding this comment.
xml2rfc --legacy works fine. Should I migrate the document to xml2rfc v3 instead?
There was a problem hiding this comment.
I think it'd be great if you could do that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The xml2rfc tool could not resolve the references in the yang-module-versioning draft.
Also removes rfc-6991-bis reference, unused import, see #172.