Skip to content

Add instrumentation to @netlify/blobs #384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Add instrumentation to @netlify/blobs #384

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f70a5de
depend on @netlify/otel in blobs
chee Jul 24, 2025
c8011ea
add instrumentation to @netlify/blobs
chee Jul 24, 2025
a1937bf
move otel package up a notch in the ws config, because blobs needs it…
chee Jul 24, 2025
e74a984
manually toposort the node 18 test build
chee Jul 24, 2025
8b9cf29
manually toposort the release please
chee Jul 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/release-please.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,10 @@ jobs:
if: ${{ steps.release.outputs['packages/runtime-utils--release_created'] }}
env:
NODE_AUTH_TOKEN: ${{secrets.NPM_TOKEN}}
- run: npm publish packages/otel/ --provenance --access=public
if: ${{ steps.release.outputs['packages/otel--release_created'] }}
env:
NODE_AUTH_TOKEN: ${{secrets.NPM_TOKEN}}
- run: npm publish packages/blobs/ --provenance --access=public
if: ${{ steps.release.outputs['packages/blobs--release_created'] }}
env:
Expand Down Expand Up @@ -102,7 +106,3 @@ jobs:
if: ${{ steps.release.outputs['packages/vite-plugin--release_created'] }}
env:
NODE_AUTH_TOKEN: ${{secrets.NPM_TOKEN}}
- run: npm publish packages/otel/ --provenance --access=public
if: ${{ steps.release.outputs['packages/otel--release_created'] }}
env:
NODE_AUTH_TOKEN: ${{secrets.NPM_TOKEN}}
8 changes: 4 additions & 4 deletions .github/workflows/test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,9 +82,9 @@ jobs:
- name: Build
# NOTE: These are run in the specified order, so they must be in topological order
run: >-
npm run build -w ./packages/types -w ./packages/dev-utils -w ./packages/runtime-utils -w ./packages/blobs -w
./packages/edge-functions -w ./packages/functions
npm run build -w ./packages/types -w ./packages/dev-utils -w ./packages/runtime-utils -w ./packages/otel -w
./packages/blobs -w ./packages/edge-functions -w ./packages/functions
- name: Tests
run: >-
npm run test -w ./packages/types -w ./packages/dev-utils -w ./packages/runtime-utils -w ./packages/blobs -w
./packages/edge-functions -w ./packages/functions
npm run test -w ./packages/types -w ./packages/dev-utils -w ./packages/runtime-utils -w ./packages/otel -w
./packages/blobs -w ./packages/edge-functions -w ./packages/functions
1 change: 1 addition & 0 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
"packages/types",
"packages/dev-utils",
"packages/runtime-utils",
"packages/otel",
"packages/blobs",
"packages/cache",
"packages/edge-functions",
Expand All @@ -17,8 +18,7 @@
"packages/static",
"packages/dev",
"packages/nuxt-module",
"packages/vite-plugin",
"packages/otel"
"packages/vite-plugin"
],
"version": "0.0.0",
"scripts": {
Expand Down
1 change: 1 addition & 0 deletions packages/blobs/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@
},
"dependencies": {
"@netlify/dev-utils": "4.1.1",
"@netlify/otel": "^3.1.0",
"@netlify/runtime-utils": "2.1.0"
}
}
Loading
Loading