Add @netlify/otel affordances #363
Draft
+151
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chee
changed the title
Some default instrumentations are included: - https://www.npmjs.com/package/@opentelemetry/instrumentation-http - https://www.npmjs.com/package/@opentelemetry/instrumentation-fetch - https://www.npmjs.com/package/@opentelemetry/instrumentation-undici The http and undici instrumentations are in devDependencies because their packages include non-esm code that made the serverless-functions-api repo cry when i tried to use them there. lmk if there's a better way to go about this
chee
changed the title
chee
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow consumers to use things like this if they want:
Once we've found some common patterns we can come back and add them as defaults in here.
(Those things get us a LOT of info by default, before we've even started adding our own instrumentation direct to blobs etc.
The other things i've added are:
withActiveSpan(getTracer(), name, (span?) => {})convenience functiona more ergonomic API than having to repeat yourself, writing the function in one place and then conditionally calling it inside or outside a loop depending on if you got a tracer. The callback gets
Span|undefinedas its arg.