Add @netlify/otel affordances #363
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chee
changed the title
Some default instrumentations are included: - https://www.npmjs.com/package/@opentelemetry/instrumentation-http - https://www.npmjs.com/package/@opentelemetry/instrumentation-fetch - https://www.npmjs.com/package/@opentelemetry/instrumentation-undici The http and undici instrumentations are in devDependencies because their packages include non-esm code that made the serverless-functions-api repo cry when i tried to use them there. lmk if there's a better way to go about this
chee
changed the title
chee
changed the title
JakeChampion
approved these changes
Jul 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instrumentationsandspanProcessorsHooks into the initialization, to be able to set the instrumentations and span processors that will be used by the tracer. I expect to write our own instrumentations that will be exported as extra entrypoints from this package, and for consuming applications to be able to pick and choose their faves.
I've added
extraSpanProcessersto make it easier to pop a local trace exporter to otel-desktop-viewer or the like when debugging in repos that depend on@netlify/otel.withActiveSpan(getTracer(), name, (span?) => {})convenience functionA more ergonomic API than having to repeat yourself, writing the function in one place and then conditionally calling it inside or outside a loop depending on if you got a tracer. The callback gets
Span|undefinedas its arg so you can know if you're running in a trace.I expect this to a temporary measure, that will be less necessary when we can load OpenTelemetry all the time and swap out for the
NoopSpanProcessorwhen the header is absent.