feat: update node version to 24 #7746
Merged
+30
−104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VitaliyR
commented
Oct 28, 2025
|
|
||
| // Captures `pnpx netlify ...` | ||
| if (pkgFromUserAgent(npm_config_user_agent) === 'pnpm' && npm_command === 'run-script') { | ||
| if (pkgFromUserAgent(npm_config_user_agent) === 'pnpm' && ['run-script', 'run'].includes(npm_command ?? '')) { |
There was a problem hiding this comment.
in node 24 on unix this has changed, and pnpm sets npm_command to run instead
e2e/install.e2e.ts
Outdated
| // At this point, the project is built. As long as we limit the prepublish script to built- | ||
| // ins, node_modules are not be necessary to publish the package. | ||
| filter: isNotNodeModules, | ||
| filter: copyFilter, |
There was a problem hiding this comment.
when run locally on mac os sometimes it tries to copy a socket-file which crashes the test, added a function which makes sure to skip it
serhalp
approved these changes
Oct 28, 2025
e2e/install.e2e.ts
Outdated
| const isNodeModules = picomatch('**/node_modules/**') | ||
| const isNotNodeModules = (target: string) => !isNodeModules(target) | ||
| const isNodeModules = picomatch('**/node_modules/**', { dot: true }) | ||
| const copyFilter = async (src: string) => { |
There was a problem hiding this comment.
nit: copyFilter doesn't express the intent of this function, at least to me. it sounds like it copies a filter!
Suggested change
| const copyFilter = async (src: string) => { | |
| const shouldCopyCLIFile = async (src: string) => { |
| os: [ubuntu-latest, macOS-latest, windows-2025] | ||
| # Pinning 20.x version as a temporary workaround due to this https://github.com/nodejs/node/issues/52884 | ||
| node-version: ['20.12.2', '22'] | ||
| node-version: ['20.12.2', '22', '24'] |
There was a problem hiding this comment.
suggestion: can we delete the copy-pasted integration-win-node-23 job in this file now? 🙏🏼
| matrix: | ||
| os: [ubuntu-latest, macOS-latest, windows-2025] | ||
| node-version: ['20.12.2', '22.x'] | ||
| node-version: ['20.12.2', '22.x', '24'] |
There was a problem hiding this comment.
💭 Don't forget to mark the new e2e + integration + unit v24 CI jobs as required when you merge!
VaibhavAcharya
pushed a commit
that referenced
this pull request
Oct 30, 2025
* feat: update node version to 24 * fix: fix pnpm on node 24 and running e2e test locally on unix * chore: remove node 23 win test and keep node 22 win test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 Thanks for submitting a pull request! 🎉
Summary
For us to review and ship your PR efficiently, please perform the following steps:
passes our tests.
A picture of a cute animal (not mandatory, but encouraged)