fix: bundle edge functions if they exist on deploy --no-build #7743
Conversation
pieh
force-pushed
the
fix/bundle-edge-functions-on-no-build-deploy
branch
from
236579a to
1690d6d
Compare
…nd use inline config, also add cases for internal and framework functions
pieh
force-pushed
the
fix/bundle-edge-functions-on-no-build-deploy
branch
from
1690d6d to
dabc560
Compare
pieh
force-pushed
the
fix/bundle-edge-functions-on-no-build-deploy
branch
from
5602c96 to
4fe4444
Compare
| // (cachedConfig type error hides this one, but it still is valid) @ts-expect-error FIXME(serhalp): This is missing from the `runCoreSteps` type in @netlify/build | ||
| edgeFunctionsBootstrapURL: await getBootstrapURL(), | ||
| // @ts-expect-error 'CachedConfig' is not assignable to type 'Record<string, unknown>'. | ||
| // Index signature for type 'string' is missing in type 'CachedConfig'. | ||
| cachedConfig: command.netlify.cachedConfig, |
There was a problem hiding this comment.
this is a bit frustrating, once I do add cachedConfig here, it no longer complain about edgeFunctionsBootstrapURL and now it actually complain about @ts-expect-error for it ... but this is still valid, just somehow hidden because of cachedConfig type error ...
Passing cachedConfig seems needed to properly support --cwd other/dir case, as otherwise bundling was trying to look in current directory and there doesn't seem to be other arguments we can pass to tell it to look elsewhere (despite passing cwd explitly above).
| // build flag wasn't used and edge functions directories exist | ||
| if (!options.build && (await anyEdgeFunctionsDirectoryExists(command))) { | ||
| // for the case of directories existing but not containing any edge functions, | ||
| // there is early bail in edge functions bundling after scanning for edge functions | ||
| // for this case and to avoid replicating scanning logic here, we defer to the bundling step | ||
| await bundleEdgeFunctions(options, command) | ||
| } |
There was a problem hiding this comment.
the previous condition doesn't seem to be met unless you specify some edge functions configuration in toml (?) so instead we check if there are edge functions dir present and trigger on-demand edge bundling if they are
if directories exist but contain on edge functions - there will be early bail - that's just edge bundling function step in @netlify/build works, so I opted not trying to repeat same logic here
🎉 Thanks for submitting a pull request! 🎉
Summary
Fixes https://linear.app/netlify/issue/FRB-2024/ensure-edge-functions-are-bundled-with-no-build-option
For us to review and ship your PR efficiently, please perform the following steps:
passes our tests.
A picture of a cute animal (not mandatory, but encouraged)