fix: respect build plugins changing build.publish
#6133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/utils/run-build.mjs
Outdated
| @@ -123,6 +123,7 @@ export const runNetlifyBuild = async ({ command, env = {}, options, settings, ti | |||
| await devCommand({ | |||
| command: undefined, | |||
| useStaticServer: true, | |||
| dist: options.dir ? undefined : netlifyConfig?.build?.publish, | |||
There was a problem hiding this comment.
Hmm this feels a bit odd. Is it because options.dir takes precedence and devCommand will find it on its own? If so, would it make sense to always send dist but make it prefer options.dir over netlifyConfig?.build?.publish?
There was a problem hiding this comment.
Agree it feels odd. But, always sending dist will effectively override all settings that come out of detectServerSettings, so i'd prefer not to do that.
Now that I think about it, undefined will also override dist because it's being destructured in devCommand - gonna need to change this.
eduardoboucas
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on netlify/angular-runtime#67, I noticed we're not respecting build plugins changing
build.publish. We should! This PR fixes that.