Skip to content

fix: remove node-fetch from edge-bundler package #6381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 27, 2025

Conversation

mrstork
Copy link
Contributor

@mrstork mrstork commented May 23, 2025

Summary

Now that we use node >18 we can drop the node-fetch polyfill from the package
Part of FRB-1833


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures
    we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or
    something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures
    your code follows our style guide and passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

@@ -48,7 +48,7 @@
"@vitest/coverage-v8": "^0.34.0",
"archiver": "^7.0.0",
"chalk": "^5.4.0",
"nock": "^13.2.4",
"nock": "^14.0.0",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Allows us to mock out native fetch calls

@mrstork mrstork marked this pull request as ready for review May 23, 2025 17:17
@mrstork mrstork requested a review from a team as a code owner May 23, 2025 17:17
@mrstork mrstork force-pushed the edge-bundler-remove-node-fetch branch 2 times, most recently from b880d66 to 86cb11d Compare May 23, 2025 20:12
@mrstork mrstork enabled auto-merge (squash) May 27, 2025 02:27
@mrstork mrstork merged commit 354f1b1 into main May 27, 2025
32 of 33 checks passed
@mrstork mrstork deleted the edge-bundler-remove-node-fetch branch May 27, 2025 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants