feat: restrict requirements for enhanced secret scan matches #6379
Conversation
|
This pull request adds or modifies JavaScript ( |
| 'key="ghp_123456789012345678"', // GitHub personal access token | ||
| 'key="sk_123456789012345678"', // Stripe key | ||
| 'key="aws_123456789012345678"', // AWS access key |
There was a problem hiding this comment.
Does the regex work if there's whitespace around the =?
There was a problem hiding this comment.
it does, as long as there's open quotes (single, double or backticks), I've added a test case for that!
…-be-considered-a-secret-to-prevent
|
This pull request adds or modifies JavaScript ( |
1 similar comment
|
This pull request adds or modifies JavaScript ( |
|
This pull request adds or modifies JavaScript ( |
…-be-considered-a-secret-to-prevent
|
This pull request adds or modifies JavaScript ( |
…-be-considered-a-secret-to-prevent
|
This pull request adds or modifies JavaScript ( |
aitchiss
deleted the
suzanne/wrfl-2581-tighten-up-requirements-to-be-considered-a-secret-to-prevent
branch
🎉 Thanks for submitting a pull request! 🎉
Summary
Fixes https://linear.app/netlify/issue/WRFL-2581/tighten-up-requirements-to-be-considered-a-secret-to-prevent-false
Secrets must now:
For us to review and ship your PR efficiently, please perform the following steps:
we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or
something that`s on fire 🔥 (e.g. incident related), you can skip this step.
your code follows our style guide and passes our tests.
A picture of a cute animal (not mandatory, but encouraged)