-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove released feature flag for extensions/ future state #5926
Conversation
91d9c7c
to
60c4cc8
Compare
This pull request adds or modifies JavaScript ( |
@@ -162,8 +125,8 @@ const getIntegrations = async function ({ | |||
|
|||
const baseUrl = new URL(host ? `http://${host}` : `https://api.netlifysdk.com`) | |||
|
|||
// use future state feature flag | |||
const url = useV2Endpoint | |||
// if accountId isn't present, use safe v1 endpoint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this for backwards compatibility? I was expecting us to fully switch over to the new endpoint without the feature flag, but is it the case that there might still something still calling this code without an account id once this code goes out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Honestly this is just because I don't know if there would ever be a case where accountId isn't present. 😎 The config package has a few mysterious optional types on things like accountId
where I'd anticipate them to always be present, but there's no comments around why they were marked as optional.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's fair enough. I was maybe being a little greedy thinking that we might even be able to get rid of the whole api endpoint for ${baseUrl}site/${siteId}/integrations/safe
in the other system. No change needed here, I was just learning.
Looks good to me from the context I remember from when this logic was added previously. |
🎉 Thanks for submitting a pull request! 🎉
Summary
Cleaning up feature flag now that it's been turned on for months now :)
For us to review and ship your PR efficiently, please perform the following steps:
we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or
something that`s on fire 🔥 (e.g. incident related), you can skip this step.
your code follows our style guide and passes our tests.
A picture of a cute animal (not mandatory, but encouraged)