Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: detect bun.lock files in addition to bun.lockb files #5918

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

mrstork
Copy link
Contributor

@mrstork mrstork commented Dec 4, 2024

🎉 Thanks for submitting a pull request! 🎉

Summary

Fixes FRB-1355
Feature is not released yet so we can wait to merge if we'd like, but it doesn't hurt to get ahead
See: oven-sh/bun#11863


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures
    we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or
    something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures
    your code follows our style guide and passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

@mrstork mrstork requested a review from a team as a code owner December 4, 2024 16:43
@mrstork mrstork enabled auto-merge (squash) December 10, 2024 18:19
@mrstork mrstork merged commit 689a8dd into main Dec 10, 2024
38 checks passed
@mrstork mrstork deleted the extend-bun-detection branch December 10, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants