NGSTACK-1000 upgrade bundle to ibexa v5 #14
Conversation
…ge fieldType handler
…' GitHub workflow
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - uses: docker://oskarstark/php-cs-fixer-ga | ||
| - uses: docker://oskarstark/php-cs-fixer-ga:3.26.0 |
There was a problem hiding this comment.
Not a good idea. This will pretty quickly be obsolete.
What's the reason for this?
There was a problem hiding this comment.
Well, the latest docker image uses PHP 8.4 version. This then causes php-cs-fixer to report things that it might not report if PHP 8.3 version was used.
Why will this become quickly obsolete? I can revert the commit back if you want.
There was a problem hiding this comment.
Are there any concrete issues?
Why will this become quickly obsolete? I can revert the commit back if you want.
Maybe we'll need to use a rule that's available only in latest version, and then this will fail.
There was a problem hiding this comment.
9825a71 removed the specific version of this php-cs-fixer image
…ng_standards.yml' file
…' file in order for php-cs-fixer workflow to pass
|
@emodric For php-cs-fixer, I just had to comment out the mb_str_functions key that was in For tests, I had to downgrade PHPUnit to version 10 because of the test that involves testing the Twig Extensions - |
…ass config" This reverts commit 7c644ab.
2 participants
Upgraded bundle to use Ibexa version 5, PHP 8.3 and Symfony 7.3. Changed some classes to use constructor promotion and fixed tests. Modified 'tests' GitHub workflow to also use PHP 8.3 and Symfony 7.3.
Look at the commits made - I think they are nice and clear enough to conclude what has been changed (nothing out of the ordinary).