Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2 to v3 utils #138

Merged
merged 19 commits into from
Dec 9, 2024
Merged

V2 to v3 utils #138

merged 19 commits into from
Dec 9, 2024

Conversation

jtdub
Copy link
Contributor

@jtdub jtdub commented Nov 20, 2024

closes #136

@jtdub jtdub requested a review from aedwardstx November 20, 2024 04:49
@jtdub jtdub self-assigned this Nov 20, 2024
@jtdub jtdub marked this pull request as draft November 20, 2024 04:49
@jtdub jtdub changed the title WIP | V2 to v3 utils V2 to v3 utils Nov 20, 2024
@jtdub jtdub marked this pull request as ready for review November 20, 2024 20:18
@jtdub jtdub requested a review from aedwardstx November 23, 2024 03:34
aedwardstx
aedwardstx previously approved these changes Dec 9, 2024
Copy link
Collaborator

@aedwardstx aedwardstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few comments, looks good otherwise

@aedwardstx
Copy link
Collaborator

Nice work! If you don't mind a bit of scope creep, please add a quick getting started section to the readme.md. If not, I'll happily add one in my next PR.

@jtdub jtdub merged commit ead4659 into master Dec 9, 2024
4 checks passed
@jtdub jtdub deleted the v2-to-v3-utils branch December 9, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

V2 -> V3 Utils
2 participants