Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes: #18584 Add rack types column to manufacturers table #18636

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

renatoalmeidaoliveira
Copy link
Collaborator

Fixes: #18584 Add rack types column to manufacturers table

  • Add Add racktype_count annotation to list view queryset
  • create the LinkedCountColumn in ManufacturerTable

The result is the following image
image

Aditional Thougts:

  • The issue makes the following statement:

Currently, users can assign manufacturers when creating rack types; however, there isn’t a straightforward way to view or filter these rack types by manufacturer within the interface.

  • IMO only adding the Rack Types Collumn in the Manufacturer List View isn't enougth to solve the user issue.
  • Looking at RackTypeFilterForm code the manufacturer_id field are defined but since it isn't referenced in any FieldSet the user are unable to select a Manufacturer to the filter.
  • That's a really quick fix but sligtly outside the issue scope, so let me know if I should add the manufacturer_id field inside some filterset
  • The Rack Type FilterSet seens the best option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add rack types column to manufacturers table
1 participant