Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes: #17796 Custom Field Choices -> Create & Add Another causes IndexError #18631

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fixes: #17796 Custom Field Choices -> Create & Add Another causes IndexError #18631

wants to merge 2 commits into from

Conversation

renatoalmeidaoliveira
Copy link
Collaborator

Fixes: #17796 Custom Field Choices -> Create & Add Another causes IndexError

  • In the current release this issue doesn't raises an Exception, but setups a wrong vaule to the form after clicking in Create & Add Another
  • The fix consists in convert the array query into a string to fit the Form field that is an CharField
  • It should be possible to change the behaiviour of prepare_cloned_fields, but IMO that may lead to unwanted collateral effects, and its leads to a more complex solution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arthanson arthanson Awaiting requested review from arthanson

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Custom Field Choices -> Create & Add Another causes IndexError
1 participant
@renatoalmeidaoliveira