Fixes 18208: Consolidate rendering configuration templates #18604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The (mostly) redundant 'DeviceRenderConfigView' and 'VirtualMachineRenderConfigView' have been merged into a single 'ObjectRenderConfigView'.
jeremystretch
approved these changes
Feb 10, 2025
There was a problem hiding this comment.
Thanks for tackling this @alehaa! I've just made some minor tweaks:
- Return a default value from
get_extra_context_data() - Moved the VIewTabs to the subclasses (mostly just so their weights are visible relative to their peer views)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #18208
The (mostly) redundant
DeviceRenderConfigViewandVirtualMachineRenderConfigViewhave been merged into a singleObjectRenderConfigView.Although a common
objectrendering context variable would be a bit cleaner, the originaldeviceandvirtualmachinevariables have been preserved. Possible future extensions could add additional values by inheriting the view and overriding theget_extra_context_data()method.