Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes 17309: Omit empty related models #18603

Merged
merged 1 commit into from
Feb 10, 2025
Merged

Fixes 17309: Omit empty related models #18603

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions netbox/templates/inc/panels/related_objects.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@ <h2 class="card-header">{% trans "Related Objects" %}</h2>
</a>
{% endif %}
{% endwith %}
{% empty %}
<span class="list-group-item text-muted">{% trans "None" %}</span>
{% endfor %}
</ul>
</div>
5 changes: 4 additions & 1 deletion netbox/utilities/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,10 @@ def get_related_models(self, request, instance, omit=[], extra=[]):
]
related_models.extend(extra)

return sorted(related_models, key=lambda x: x[0].model._meta.verbose_name.lower())
return sorted(
filter(lambda qs: qs[0].exists(), related_models),
key=lambda qs: qs[0].model._meta.verbose_name.lower(),
)


class ViewTab:
Expand Down