16424 - Allow filtering of Devices by Cluster and Cluster Group #16674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er_and_cluster_group
…er_and_cluster_group
jeremystretch
requested changes
Jun 24, 2024
There was a problem hiding this comment.
@Julio-Oliveira-Encora could you please add filterset tests for these?
jeremystretch
approved these changes
Jun 26, 2024
There was a problem hiding this comment.
Note that for models with a slug field, we need filters for both the ID and slug. I went ahead and added the second filter & updated the test. Thanks @Julio-Oliveira-Encora!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #16424
It was added to filtering Devices by Cluster Group and Cluster.