Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

16252 only show results count if paginator #16269

Merged
merged 3 commits into from
Jun 21, 2024
Merged

16252 only show results count if paginator #16269

merged 3 commits into from
Jun 21, 2024

Conversation

arthanson
Copy link
Collaborator

Fixes: #16252

@arthanson arthanson marked this pull request as ready for review May 23, 2024 22:08
@arthanson arthanson requested a review from jeremystretch May 23, 2024 22:08
@jeremystretch jeremystretch requested review from jeffgdotorg and jeremystretch and removed request for jeremystretch and jeffgdotorg May 28, 2024 13:34
jeremystretch
jeremystretch requested changes May 28, 2024
View reviewed changes
Copy link
Member

@jeremystretch jeremystretch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't address the root issue: RackElevationListView does not provide a table object in the template context, so the number of objects is never reported.

@arthanson arthanson requested a review from jeremystretch June 5, 2024 19:16
jeremystretch
jeremystretch requested changes Jun 6, 2024
View reviewed changes
jeremystretch
jeremystretch approved these changes Jun 21, 2024
View reviewed changes
Copy link
Member

@jeremystretch jeremystretch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @arthanson!

@jeremystretch jeremystretch merged commit dda0b0b into develop Jun 21, 2024
6 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 22, 2024
@arthanson arthanson deleted the 16252-results-tab branch December 3, 2024 16:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jeremystretch jeremystretch jeremystretch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Elevations results count span contains a dot instead of a number
2 participants
@arthanson @jeremystretch