[management] remove toAll firewall rule

[crn4]

Describe your changes

Issue ticket number and link

Stack

Checklist

• Is it a bug fix
• Is a typo/documentation fix
• Is a feature enhancement
• It is a refactor
• Created tests that fail without the change (if possible)

By submitting this pull request, you confirm that you have read and agree to the terms of the Contributor License Agreement.

Documentation

Select exactly one:

• I added/updated documentation for this change
• Documentation is not needed for this change (explain why)
  changes in firewall rules internal details

Docs PR URL (required if "docs added" is checked)

Paste the PR link from https://github.com/netbirdio/docs here:

https://github.com/netbirdio/docs/pull/__

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[Copilot]

Pull Request Overview

This PR removes the optimization that used "0.0.0.0" as a wildcard IP address in firewall rules when all peers in a group were targeted. Instead, firewall rules now explicitly list individual peer IP addresses.

• Removed the logic that calculated whether a rule applied to all peers and used "0.0.0.0" as a shorthand
• Updated firewall rule generation to always use specific peer IP addresses
• Modified test expectations to reflect explicit peer IPs instead of wildcard addresses

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
management/server/types/account.go	Removed "GetGroupAll()" call and the conditional logic that set PeerIP to "0.0.0.0" for rules applying to all peers
management/server/policy_test.go	Updated test expectations to assert on individual peer IP addresses instead of wildcard "0.0.0.0" entries, adjusting expected firewall rule counts accordingly

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.