Skip to content

next try to cleanup addon #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lfarkas wants to merge 2 commits into
base: main
Choose a base branch
from
Open

next try to cleanup addon #310

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
23fbb90
next try to cleanup addon
lfarkas Nov 20, 2025
a3f62c6
Add runtime validation for environment variables
lfarkas Nov 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/renovate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"matchStringsStrategy": "any",
"matchStrings": [
"ARG BUILD_FROM=(?<depName>.*?):(?<currentValue>.*?)\\s+",
"(aarch64|amd64|armhf|armv7|i386):\\s[\"']?(?<depName>.*?):(?<currentValue>.*?)[\"']?\\s"
"(aarch64|amd64):\\s[\"']?(?<depName>.*?):(?<currentValue>.*?)[\"']?\\s"
],
"datasourceTemplate": "docker"
},
Expand Down
8 changes: 1 addition & 7 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,6 @@

![Supports aarch64 Architecture][aarch64-shield]
![Supports amd64 Architecture][amd64-shield]
![Supports armhf Architecture][armhf-shield]
![Supports armv7 Architecture][armv7-shield]
![Supports i386 Architecture][i386-shield]

![Project Maintenance][maintenance-shield]
[![GitHub Activity][commits-shield]][commits]
Expand Down Expand Up @@ -81,17 +78,14 @@ SOFTWARE.

[aarch64-shield]: https://img.shields.io/badge/aarch64-yes-green.svg
[amd64-shield]: https://img.shields.io/badge/amd64-yes-green.svg
[armhf-shield]: https://img.shields.io/badge/armhf-yes-green.svg
[armv7-shield]: https://img.shields.io/badge/armv7-yes-green.svg
[commits-shield]: https://img.shields.io/github/commit-activity/y/lfarkas/addon-netbird.svg
Copy link

Copilot AI Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commits-shield badge URL still references lfarkas/addon-netbird, but this is inconsistent with other repository URLs in the file that point to netbirdio/addon-netbird (see line 82 for commits link). This should be updated to match the repository organization used elsewhere in the file.

Suggested change
[commits-shield]: https://img.shields.io/github/commit-activity/y/lfarkas/addon-netbird.svg
[commits-shield]: https://img.shields.io/github/commit-activity/y/netbirdio/addon-netbird.svg

Copilot uses AI. Check for mistakes.
[commits]: https://github.com/netbirdio/addon-netbird/commits/main
[discord-ha]: https://discord.gg/c5DvZ4e
[discord]: https://discord.me/hassioaddons
[docs]: https://github.com/netbirdio/addon-netbird/blob/main/netbird/DOCS.md
[forum]: https://community.home-assistant.io/t/repository-community-hass-io-add-ons/24705
[i386-shield]: https://img.shields.io/badge/i386-yes-green.svg
[issue]: https://github.com/netbirdio/addon-netbird/issues
[license-shield]: https://img.shields.io/github/license/lfarkas/addon-netbird.svg
Copy link

Copilot AI Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The license-shield badge URL still references lfarkas/addon-netbird, but this is inconsistent with other repository URLs in the file that point to netbirdio/addon-netbird. This should be updated to match the repository organization used elsewhere in the file.

Suggested change
[license-shield]: https://img.shields.io/github/license/lfarkas/addon-netbird.svg
[license-shield]: https://img.shields.io/github/license/netbirdio/addon-netbird.svg

Copilot uses AI. Check for mistakes.
[maintenance-shield]: https://img.shields.io/maintenance/yes/2023.svg
[maintenance-shield]: https://img.shields.io/maintenance/yes/2025.svg
[project-stage-shield]: https://img.shields.io/badge/project%20stage-experimental-yellow.svg
[reddit]: https://reddit.com/r/homeassistant
44 changes: 44 additions & 0 deletions netbird/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
# Changelog

All notable changes to this project will be documented in this file.

The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [v0.59.13] - 2025-11-17

### Changed
- Updated to NetBird v0.59.13
Comment on lines +8 to +11
Copy link

Copilot AI Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CHANGELOG lists version v0.59.13, but the actual version in config.yaml (line 3) and Dockerfile (line 3) is v0.60.2. The CHANGELOG version should match the actual addon version being released.

Suggested change
## [v0.59.13] - 2025-11-17
### Changed
- Updated to NetBird v0.59.13
## [v0.60.2] - 2025-11-17
### Changed
- Updated to NetBird v0.60.2

Copilot uses AI. Check for mistakes.
- **BREAKING**: Removed support for armhf, armv7, and i386 architectures
- Only aarch64 and amd64 architectures are now supported

## [v0.54.2] - 2025-11-17

### Changed
- Updated to NetBird v0.54.2
Comment on lines +15 to +18
Copy link

Copilot AI Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This entry lists version v0.54.2 with the same date as v0.59.13 (2025-11-17). It's unusual to have two different version releases on the same date. Additionally, this version appears older than v0.59.13, but is listed after it in the CHANGELOG. In Keep a Changelog format, newer versions should be listed first, with older versions below. Consider reorganizing these entries if v0.54.2 is actually an older release, or clarifying why both versions have the same release date.

Copilot uses AI. Check for mistakes.
- Improved security by masking sensitive setup key in logs
- Enhanced error handling in service startup script
- Better documentation for DNS resolver workaround

### Fixed
- Fixed inconsistent addon slug in documentation
- Fixed broken repository links
- Updated maintenance year to 2025
- Corrected default management URL across documentation

### Added
- AppArmor security profile
- Healthcheck configuration for monitoring addon status
- Improved file migration logic with better error handling
- Binary existence check before execution

### Security
- Removed sensitive credential logging
- Added AppArmor profile for enhanced security

## [Unreleased]

### Notes
- Based on hassio-addons base image 18.2.1
Copy link

Copilot AI Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CHANGELOG states the addon is "Based on hassio-addons base image 18.2.1", but the actual base image version in build.yaml is 19.0.0. This documentation should reflect the actual base image version being used.

Suggested change
- Based on hassio-addons base image 18.2.1
- Based on hassio-addons base image 19.0.0

Copilot uses AI. Check for mistakes.
- Supports aarch64 and amd64 architectures only
- Requires privileged capabilities for VPN functionality
4 changes: 2 additions & 2 deletions netbird/DOCS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ You'll find that the log generates a login URL you can use instead of configurin

### Option: `management_url`

Management Service URL [http|https]://[host]:[port] (default "<https://api.wiretrustee.com:33073>")
Management Service URL [http|https]://[host]:[port] (default "<https://api.netbird.io/>")

The client will use this URL to communicate with your NetBird instance api.

Expand Down Expand Up @@ -160,7 +160,7 @@ SOFTWARE.

[addon-badge]: https://my.home-assistant.io/badges/supervisor_addon.svg
[addon]: https://my.home-assistant.io/redirect/supervisor_addon/?addon=a0d7b954_netbird&repository_url=https%3A%2F%2Fgithub.com%2Fnetbirdio%2Faddon-netbird
[contributors]: https://github.com/hassio-addons/addon-netbird/graphs/contributors
[contributors]: https://github.com/netbirdio/addon-netbird/graphs/contributors
[discord-ha]: https://discord.gg/c5DvZ4e
[discord]: https://discord.me/hassioaddons
[forum]: https://community.home-assistant.io/t/repository-community-hass-io-add-ons/24705
Expand Down
3 changes: 0 additions & 3 deletions netbird/build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,3 @@
build_from:
aarch64: ghcr.io/hassio-addons/base:19.0.0
amd64: ghcr.io/hassio-addons/base:19.0.0
armhf: ghcr.io/hassio-addons/base:19.0.0
armv7: ghcr.io/hassio-addons/base:19.0.0
i386: ghcr.io/hassio-addons/base:19.0.0
3 changes: 0 additions & 3 deletions netbird/config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,6 @@ init: false
arch:
- aarch64
- amd64
- armhf
- armv7
- i386
host_network: true
host_dbus: true
privileged:
Expand Down
7 changes: 4 additions & 3 deletions netbird/rootfs/etc/s6-overlay/s6-rc.d/netbird/run
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ if [ "${setup_key}" = "" ]; then
bashio::log.info "No Setup Key Set"
bashio::log.info "This client will only show up in dashboards it's already registered with."
else
bashio::log.info "Using ${setup_key} as Setup Key"
bashio::log.info "Setup Key configured (hidden for security)"
options+=(--setup-key "${setup_key}")
fi

Expand Down Expand Up @@ -85,8 +85,9 @@ for var in $(bashio::config 'env_vars|keys'); do
export "${name}=${value}"
done

# dirty hack to get dns working
# with this netbird can regonize the host running systemd-resolved
# Workaround for DNS resolution with systemd-resolved
# NetBird checks for systemd-resolved by looking for a specific comment in /etc/resolv.conf
# This ensures NetBird can properly detect and configure DNS settings on the host
CONTENT=$(cat /etc/resolv.conf)
echo '# systemd-resolved' > /etc/resolv.conf
echo "$CONTENT" >> /etc/resolv.conf
Expand Down
Loading