Support both variants of Net::SSH::Service::Forward#open() #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2. Ignore *.gem files. 3. Add open() variant with 4 parameters that calls the @session.forward.local variant with 4 parameters as well.
2. Update comments.
Release 2.0.0, which was never released in the original, plus we added a feature.
mfazekas
requested changes
Dec 8, 2016
| @@ -0,0 +1 @@ | |||
| net-ssh-gateway | |||
There was a problem hiding this comment.
let's add that to .gitignore it's not needed to everyone
| ensure | ||
| close(actual_local_port) | ||
| end | ||
| def open(*args) |
There was a problem hiding this comment.
We need to keep documentation in a single place. Also it probably makes sense to follow the argument options what we have in net-ssh eg local_host in front https://github.com/net-ssh/net-ssh/blob/master/lib/net/ssh/service/forward.rb and not change that. Or go with keyword arguments.
|
@bitaxis thanks much for the PR 👍 , please also include an usecase, why you need that local_host param. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Net::SSH::Service::Forward#open() has a 3-argument variant as well as a 4-argument one. The latest published/tagged version only supports the 3-argument one. This pull request adds support for the latter as well while.
Tests are included.