-
-
Notifications
You must be signed in to change notification settings - Fork 8k
feat(platform) multer support for fastify platform #2088
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Split multer code from platform-express to his own package
Pull Request Test Coverage Report for Build 2603
💛 - Coveralls |
Pull Request Test Coverage Report for Build 2578
💛 - Coveralls |
@kamilmysliwiec WDYT? 😄 |
Thanks for the contribution. A few things:
|
@kamilmysliwiec updated, Multer package was removed and the files related interceptors was copied to platform-fastify. Please consider a common |
please let me know if you are ok with the new version to proceed to update the docs |
Thank you for your contribution @gperdomor. We have to postpone merging though because as I said:
Anyway, feel free to move forward with the docs. Once the library gets more mature, we'll surely make use of it. |
@kamilmysliwiec docs updated :D |
@kamilmysliwiec How long do you think this will take to merge this PR to master? I am using @nestjs/platform-fastify and FileUpload in my project. In the meantime, is there a way to integrate this PR to @nestjs/platform-fastify dependency? |
@kamilmysliwiec @gperdomor |
@kamilmysliwiec @gperdomor |
@kamilmysliwiec any update on it? we are missing out on performance due to this small part |
Thanks to everyone for for the interest in this PR, I will close this in favor of #4921 which basically is an updated version of this one |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
File upload using Multer is only supported for
express
adapterIssue Number: N/A
What is the new behavior?
Add
fastify-multer
support in@nestjs/platform-fastify
.Does this PR introduce a breaking change?
Other information